From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C2882947DE for ; Thu, 22 Feb 2024 11:44:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A5A436870 for ; Thu, 22 Feb 2024 11:44:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Feb 2024 11:44:52 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D04BF4488D for ; Thu, 22 Feb 2024 11:44:51 +0100 (CET) Message-ID: Date: Thu, 22 Feb 2024 11:44:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Markus Frank To: Fiona Ebner , Proxmox VE development discussion References: <20231108085254.53574-1-m.frank@proxmox.com> <20231108085254.53574-7-m.frank@proxmox.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server v8 6/7] check_local_resources: virtiofs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2024 10:44:52 -0000 On 2024-01-31 16:35, Fiona Ebner wrote: > A 'migration: ' prefix would be nice for the commit title. > > Am 08.11.23 um 09:52 schrieb Markus Frank: >> add dir mapping checks to check_local_resources >> > > So, as long as there is a mapping for the target node, the migration > check goes through. Should it? I mean, nothing ensures that the contents > of the directory are the same on the target, or? What happens if they > are not? Yes. This is similar to the PCI & USB Mapping. Nothing ensures that the mapped device/directory is the same on the other host. If the contents are not the same they will not be the same. But this should not be a problem as long as nothing in a VM depends on something in the virtiofs directory. This is something the user should take care of. Or am I missing something? > > Is migration with a directory on a shared storage reliable? With all > cache settings? I didn't encounter any problems. Since the VM has to be powered off to migrate, I assume the cache gets cleared & written to disk when virtiofs stops. > > If you already tested these things, please share them in the commit > message (and maybe also docs). Otherwise, I know nothing without testing > myself ;) Okay :)