From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DD5C091B3A for ; Thu, 9 Feb 2023 10:30:10 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6E0B21C60 for ; Thu, 9 Feb 2023 10:30:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 9 Feb 2023 10:30:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1A3C0461F6 for ; Thu, 9 Feb 2023 10:30:10 +0100 (CET) Message-ID: Date: Thu, 9 Feb 2023 10:30:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20230126134614.117709-1-f.ebner@proxmox.com> From: Fiona Ebner In-Reply-To: <20230126134614.117709-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.571 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu 1/2] fix #4476: savevm-async: avoid looping without progress X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Feb 2023 09:30:10 -0000 Should we include this before rolling out QEMU 7.2 to public repositories? Will always trigger with large disk(s), when doing a PBS backup and at any later time a snapshot/hibernation. It's not a new problem, but there were a few reports recently, and 7.2-rollout seems like a good time. Am 26.01.23 um 14:46 schrieb Fiona Ebner: > when pend_postcopy is large. By definition, pend_postcopy won't > decrease when iterating, so a value larger than the cutoff of 400000 > would lead to essentially empty iterations, filling up the state file > until only 30 MiB + pending_size remain and the second half of the > check would trigger. > > Avoid this, by not considering pend_postcopy for the cutoff to enter > the final phase. > > Signed-off-by: Fiona Ebner