From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1ADA01FF141 for ; Tue, 30 Jun 2026 15:57:09 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D345A2141E; Tue, 30 Jun 2026 15:57:07 +0200 (CEST) Message-ID: Date: Tue, 30 Jun 2026 15:57:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH container v9 06/10] add linked clone check when destroying container template To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260629140439.184878-1-m.koeppl@proxmox.com> <20260629140439.184878-7-m.koeppl@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260629140439.184878-7-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1782827811745 X-SPAM-LEVEL: Spam detection results: 0 DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VPZAO22KSFQSJ57EDQWK6QUTOUMABBF2 X-Message-ID-Hash: VPZAO22KSFQSJ57EDQWK6QUTOUMABBF2 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 29.06.26 um 4:04 PM schrieb Michael Köppl: > This check matches the behavior already implemented for VMs and prevents > partial storage deletion if a container template has a linked clone. In > such cases, the destruction of the container template will now fail, > informing the user that the base volume is still in use by the linked > clone. In case of a storage error (such as the underlying storage no > existing anymore), a warning will be printed and execution continues, > mimicking the handling of storage errors in later stages of > destroy_lxc_container(). > > Originally-by: Stefan Hrdlicka > [ MK: use classify_mountpoint instead of pattern matching > display warning for storage errors during linked clone check > resolve style nit ] > Signed-off-by: Michael Köppl > --- > src/PVE/LXC.pm | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index e76da29f..c9f3cba7 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -1024,6 +1024,25 @@ sub destroy_lxc_container { > my ($storage_cfg, $vmid, $conf, $replacement_conf, $purge_unreferenced) = @_; > > my $volids = {}; > + > + if ($conf->{template}) { > + PVE::LXC::Config->foreach_volume_full( > + $conf, > + { include_unused => 1 }, > + sub { > + my ($ms, $mountpoint) = @_; > + my $volid = $mountpoint->{volume}; > + return if !$volid || PVE::LXC::Config->classify_mountpoint($volid) ne 'volume'; > + my $result = > + eval { PVE::Storage::volume_is_base_and_used($storage_cfg, $volid) }; > + PVE::RESTEnvironment::log_warn( > + "failed to check if volume '$volid' is used by linked clones: $@") > + if $@; Style nit: multi-line post-if. If you import the log_warn() directly, it should be shorter ;) Maybe note with a comment that this is an early check and removal of the volume itself would still fail later, which is why it's fine to just log a warning here. > + die "base volume '$volid' is still in use by linked clone\n" if $result; > + }, > + ); > + } > + > my $remove_volume = sub { > my ($ms, $mountpoint) = @_; >