From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C5F0D75073 for <pve-devel@lists.proxmox.com>; Wed, 23 Jun 2021 12:07:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C37DF98BF for <pve-devel@lists.proxmox.com>; Wed, 23 Jun 2021 12:07:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 56C6D98B1 for <pve-devel@lists.proxmox.com>; Wed, 23 Jun 2021 12:07:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3B67D46736 for <pve-devel@lists.proxmox.com>; Wed, 23 Jun 2021 12:07:03 +0200 (CEST) Message-ID: <cb2dec51-d1ac-e883-b143-9ce3d42ab38d@proxmox.com> Date: Wed, 23 Jun 2021 12:06:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Stefan Reiter <s.reiter@proxmox.com> References: <20210621163542.1752647-1-s.reiter@proxmox.com> <20210621163542.1752647-2-s.reiter@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20210621163542.1752647-2-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.664 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server 1/2] use KillMode 'process' for systemd scope X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 23 Jun 2021 10:07:03 -0000 On 21.06.21 18:35, Stefan Reiter wrote: > KillMode 'none' is deprecated, and systemd loudly complains about that > in the journal. To avoid the warning, but keep the behaviour the same, > use KillMode 'process'. > > This mode does two things differently, which we have to stop it from > doing: > * it sends SIGTERM right when the scope is cancelled (e.g. on shutdown) > -> but only to the "root" process, which in our case is the worker > instance forking QEMU, so it is already dead by the time this happens > * it sends SIGKILL to *all* children after a timeout > -> can be avoided by setting either SendSIGKILL to false, or > TimeoutStopUSec to infinity - for safety, we do both > > In my testing, this replicated the previous behaviour exactly, but > without using the deprecated 'none' mode. > > Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> > --- > > Depends on updated pve-common from patch 2. > > PVE/QemuServer.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks!