From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B73E41FF15F for ; Mon, 21 Oct 2024 13:53:11 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 036C533280; Mon, 21 Oct 2024 13:53:48 +0200 (CEST) Message-ID: Date: Mon, 21 Oct 2024 13:53:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Filip Schauer References: <20240918144953.130780-1-f.schauer@proxmox.com> <20240918144953.130780-3-f.schauer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240918144953.130780-3-f.schauer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.057 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 storage 2/6] api: content: implement moving a volume between storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 18.09.24 um 16:49 schrieb Filip Schauer: > +sub volume_move { > + my ($cfg, $source_volid, $target_storeid, $delete) = @_; > + > + my ($source_storeid, $source_volname) = PVE::Storage::parse_volume_id($source_volid, 0); > + > + die "source and target storage cannot be the same\n" if $source_storeid eq $target_storeid; > + > + my $source_scfg = PVE::Storage::storage_config($cfg, $source_storeid); > + my $source_plugin = PVE::Storage::Plugin->lookup($source_scfg->{type}); > + my ($vtype) = $source_plugin->parse_volname($source_volname); > + > + die "source storage '$source_storeid' does not support volumes of type '$vtype'\n" > + if !$source_scfg->{content}->{$vtype}; > + > + my $target_scfg = PVE::Storage::storage_config($cfg, $target_storeid); > + die "target storage '$target_storeid' does not support volumes of type '$vtype'\n" > + if !$target_scfg->{content}->{$vtype}; > + > + die "use pct move-volume or qm disk move\n" if $vtype eq 'images' || $vtype eq 'rootdir'; > + die "moving volume of type '$vtype' not implemented\n" > + if ($vtype ne 'iso' && $vtype ne 'vztmpl' && $vtype ne 'snippets'); > + > + PVE::Storage::activate_storage($cfg, $source_storeid); > + > + die "expected storage '$source_storeid' to be path based\n" if !$source_scfg->{path}; > + my $source_path = $source_plugin->path($source_scfg, $source_volname, $source_storeid); > + die "$source_path does not exist" if (!-e $source_path); > + my $source_dirname = dirname($source_path); > + > + die "expected storage '$target_storeid' to be path based\n" if !$target_scfg->{path}; > + my $target_plugin = PVE::Storage::Plugin->lookup($target_scfg->{type}); > + my $target_path = $target_plugin->path($target_scfg, $source_volname, $target_storeid); > + > + PVE::Storage::activate_storage($cfg, $target_storeid); > + die "$target_path already exists" if (-e $target_path); > + What if a volume with the same name is created after this check, but before the move/copy? I guess you'll need to lock the storage (see e.g. vdisk_alloc() in Storage.pm for comparison). > + my @created_files = (); > + > + eval { > + if ($delete) { > + move($source_path, $target_path) or die "failed to move $vtype: $!"; > + } else { > + copy($source_path, $target_path) or die "failed to copy $vtype: $!"; > + } > + }; > + if (my $err = $@) { > + for my $created_file (@created_files) { > + unlink $created_file or $!{ENOENT} or warn $!; > + } > + die $err; > + } > + > + PVE::Storage::archive_remove($source_path) if $delete; > + > + return; _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel