From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 10A101FF17C for ; Wed, 3 Sep 2025 18:01:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 19E5E123DE; Wed, 3 Sep 2025 18:01:26 +0200 (CEST) Message-ID: Date: Wed, 3 Sep 2025 18:01:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Wolfgang Bumiller References: <20250902125516.346145-1-w.bumiller@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <20250902125516.346145-1-w.bumiller@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756915267126 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [nodes.pm] Subject: Re: [pve-devel] [PATCH manager] api: factor out shell command schema X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 02.09.25 um 14:55 schrieb Wolfgang Bumiller: > So we only sort the enum keys once and the documentation and API dumps > don't keep reordering them, and to deduplicate the cmd and cmd-opts > schema. > > Signed-off-by: Wolfgang Bumiller > --- > PVE/API2/Nodes.pm | 68 ++++++++++++++--------------------------------- > 1 file changed, 20 insertions(+), 48 deletions(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index ce7eecaf1..636789277 100644 > --- a/PVE/API2/Nodes.pm > +++ b/PVE/API2/Nodes.pm > @@ -1103,6 +1103,23 @@ my $shell_cmd_map = { > }, > }; > > +my @shell_cmd_params = ( not really much difference in practice, but why not a %hash map? > + cmd => { > + type => 'string', > + description => "Run specific command or default to login (requires 'root\@pam')", > + enum => [sort keys %$shell_cmd_map], > + optional => 1, > + default => 'login', > + }, > + 'cmd-opts' => { > + type => 'string', > + description => "Add parameters to a command. Encoded as null terminated strings.", > + requires => 'cmd', > + optional => 1, > + default => '', > + }, > +); > + _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel