From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.schauer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 3CEF293576
 for <pve-devel@lists.proxmox.com>; Tue,  9 Apr 2024 11:27:38 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 2489B1A643
 for <pve-devel@lists.proxmox.com>; Tue,  9 Apr 2024 11:27:38 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue,  9 Apr 2024 11:27:37 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3349142E8C
 for <pve-devel@lists.proxmox.com>; Tue,  9 Apr 2024 11:27:37 +0200 (CEST)
Message-ID: <c93d1c93-de37-4850-a447-bd2267fa41b9@proxmox.com>
Date: Tue, 9 Apr 2024 11:27:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
References: <20240325172829.26262-1-f.schauer@proxmox.com>
 <20240325172829.26262-2-f.schauer@proxmox.com>
 <mucnjjldfri77fnrhhx6ouqjc3valdous6r6i3fxvdyyny3blo@cyj4xeixwf6u>
Content-Language: en-US
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <mucnjjldfri77fnrhhx6ouqjc3valdous6r6i3fxvdyyny3blo@cyj4xeixwf6u>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.081 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 container 1/2] fix #5160: fix move_mount
 regression for mount point hotplug
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 09 Apr 2024 09:27:38 -0000

Agreed. This appear to be a leftover from testing. A patch v3 with this
removed is available:

https://lists.proxmox.com/pipermail/pve-devel/2024-April/062693.html

On 09/04/2024 10:23, Wolfgang Bumiller wrote:
>> diff --gita/src/pve-container-debug@.service  b/src/pve-container-debug@.service
>> index 7cfebaa..cd0895c 100644
>> ---a/src/pve-container-debug@.service
>> +++b/src/pve-container-debug@.service
>> @@ -13,6 +13,7 @@ Type=simple
>>   Delegate=yes
>>   KillMode=mixed
>>   TimeoutStopSec=120s
>> +ExecStartPre=/lib/apparmor/profile-load pve-container-mounthotplug
>>   ExecStart=/usr/bin/lxc-start -F -n %i -o /dev/stderr -l DEBUG
>>   ExecStop=/usr/share/lxc/pve-container-stop-wrapper %i
>>   # Environment=BOOTUP=serial
> ^ This hunk should be dropped. The entry in d/rules is enough, and this
> is the wrong place anyway, as this is triggered when starting a new
> container, and not when hotplugging.