From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A734369FFA for ; Mon, 15 Feb 2021 16:00:13 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95924CB4B for ; Mon, 15 Feb 2021 15:59:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D6981CB3C for ; Mon, 15 Feb 2021 15:59:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9627746252 for ; Mon, 15 Feb 2021 15:59:41 +0100 (CET) To: pve-devel@lists.proxmox.com References: <20201215124840.29914-1-a.lauterer@proxmox.com> From: Aaron Lauterer Message-ID: Date: Mon, 15 Feb 2021 15:59:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20201215124840.29914-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.019 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v5 series 0/5] disk reassign: add new feature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Feb 2021 15:00:13 -0000 Bump in case this has been missed. :) The patches should still apply fine. (just tested) On 12/15/20 1:48 PM, Aaron Lauterer wrote: > This series implements a new feature which allows users to easily > reassign disks between VMs. Currently this is only possible with one of > the following manual steps: > > * rename the disk image/file and do a `qm rescan` > * configure the disk manually and use the old image name, having an > image for VM A assigned to VM B > > The latter can cause unexpected behavior because PVE expects that the > VMID in a disk name always corresponds to the VM it is assigned to. Thus > when a disk, original from VM A was manually configured as disk for VM B > it happens that, when deleting VM A, the disk in question will be > deleted as well because it still had the VMID of VM A in it's name. > > To issue a reassign from the CLI run: > > qm reassign_disk > > where is the config key of the disk, e.g. ide0, scsi1 and so > on. > > The following storage types are implemented at the moment: > * dir based ones > * directory > * NFS > * CIFS > * gluster > * ZFS > * (thin) LVM > * Ceph RBD > > > v4 -> v5: > * rebase on current master > * reorder patches > * rename `drive_key` to `drive_name` > thanks @Dominic for pointing out that there already are a lot of > different names in use for this [0] and not to invent another one ;) > * implemented suggested changes from Fabian [1][2]. More directly in the > patches themselves > > v3 -> v4: > * revert intermediate storage plugin for directory based plugins > * add a `die "not supported"` method in Plugin.pm > * dir based plugins now call the file_reassign_volume method in > Plugin.pm as the generic file/directory based method > * restored old `volume_has_feature` method in Plugin.pm and override it > in directory based plugins to check against the new `reassign` feature > (not too happy about the repetition for each plugin) > * task description mapping has been moved from widget-toolkit to > pve-manager/utils > > > v2 -> v3: > * change locking approach > * add more checks > * add intermedia storage plugin for directory based plugins > * use feature flags > * split up the reassign method to have a dedicated method for the > renaming itself > * handle linked clones > * clean up if disk used to be replicated > > I hope I didn't forget anything major. > > v1 -> v2: > print info about the new disk volid and key at the end of the job so it > shows up in the CLI output and task log > > Changes from RFC -> V1: > * support to reassign unused disks > * digest for target vm config > * reorder the checks a bit > * adding another one to check if the given key for the disk even exists > in the config. > > [0] https://lists.proxmox.com/pipermail/pve-devel/2020-November/045986.html > [1] https://lists.proxmox.com/pipermail/pve-devel/2020-November/046031.html > [2] https://lists.proxmox.com/pipermail/pve-devel/2020-November/046030.html > > storage: Aaron Lauterer (1): > add disk reassign feature > > PVE/Storage.pm | 15 ++++++++-- > PVE/Storage/CIFSPlugin.pm | 19 +++++++++++++ > PVE/Storage/DirPlugin.pm | 19 +++++++++++++ > PVE/Storage/GlusterfsPlugin.pm | 19 +++++++++++++ > PVE/Storage/LVMPlugin.pm | 24 ++++++++++++++++ > PVE/Storage/LvmThinPlugin.pm | 1 + > PVE/Storage/NFSPlugin.pm | 19 +++++++++++++ > PVE/Storage/Plugin.pm | 51 ++++++++++++++++++++++++++++++++++ > PVE/Storage/RBDPlugin.pm | 31 +++++++++++++++++++++ > PVE/Storage/ZFSPoolPlugin.pm | 28 +++++++++++++++++++ > 10 files changed, 224 insertions(+), 2 deletions(-) > > > qemu-server: Aaron Lauterer (2): > disk reassign: add API endpoint > cli: disk reassign: add reassign_disk to qm command > > PVE/API2/Qemu.pm | 151 ++++++++++++++++++++++++++++++++++++++++ > PVE/CLI/qm.pm | 2 + > PVE/QemuServer/Drive.pm | 4 ++ > 3 files changed, 157 insertions(+) > > > guest-common: Aaron Lauterer (1): > Replication: mention disk reassign in comment of possible reasons > > PVE/Replication.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > manager: Aaron Lauterer (1): > ui: tasks: add qmreassign task description > > www/manager6/Utils.js | 1 + > 1 file changed, 1 insertion(+) > >