From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 44BF51FF0A3 for ; Thu, 01 Oct 2026 14:07:33 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D29AB21719; Thu, 01 Oct 2026 14:07:22 +0200 (CEST) Message-ID: Date: Thu, 1 Oct 2026 14:07:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner Subject: Re: [PATCH many v6 00/18] add option to prevent suggesting previously used VMIDs To: =?UTF-8?Q?Michael_K=C3=B6ppl?= , pve-devel@lists.proxmox.com References: <20260924161510.847362-1-m.koeppl@proxmox.com> Content-Language: en-US In-Reply-To: <20260924161510.847362-1-m.koeppl@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790856438831 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.486 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YUDDXZUH3DRVJRJGMD6ARIXCM7GVGM6A X-Message-ID-Hash: YUDDXZUH3DRVJRJGMD6ARIXCM7GVGM6A X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 24.09.26 um 6:16 PM schrieb Michael Köppl: > This is based on the original series [0] by Severen Redwood and Daniel > Krambrock. It is rebased on the latest master branches and incorporates > the feedback from v5 [1]. This is coming along nicely. There is some polishing and naming improvements left to be done, but it looks very good to me in general! The UI always shows "This VM ID is already in use" when the next-id endpoint fails and doesn't properly propagate the actual error from the backend. For completeness, you could add a pve-docs patch to describe the new file in pmxcfs.adoc