From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8ACB9741C3 for ; Mon, 21 Jun 2021 09:53:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7969518E44 for ; Mon, 21 Jun 2021 09:53:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1481F18E36 for ; Mon, 21 Jun 2021 09:53:25 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D650340574 for ; Mon, 21 Jun 2021 09:53:24 +0200 (CEST) To: Thomas Lamprecht , Proxmox VE development discussion References: <20210616093604.33668-1-l.stechauner@proxmox.com> <20210616093604.33668-6-l.stechauner@proxmox.com> <07cd6245-dced-f397-02da-0873851f3a31@proxmox.com> From: Lorenz Stechauner Message-ID: Date: Mon, 21 Jun 2021 09:53:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <07cd6245-dced-f397-02da-0873851f3a31@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.776 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH v9 manager 2/5] api: nodes: refactor aplinfo to use common download function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jun 2021 07:53:58 -0000 On 18.06.21 18:58, Thomas Lamprecht wrote: > On 16.06.21 11:36, Lorenz Stechauner wrote: >> a common function to download arbitrary files from urls has been >> defined as PVE::Tools::download_file_from_url and is now used. >> >> Signed-off-by: Lorenz Stechauner >> --- >> PVE/API2/Nodes.pm | 93 +++++++++-------------------------------------- >> 1 file changed, 17 insertions(+), 76 deletions(-) >> >> > applied, with the $rpcenv/$user re-definitions dropped in a followup, plus > some more cleanup (please check if it seems OK for you), thanks! Had a look at the followups. they look good to me