From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 42DB66A8DA for ; Fri, 5 Mar 2021 21:35:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1CC0D29387 for ; Fri, 5 Mar 2021 21:34:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 51B3E2936A for ; Fri, 5 Mar 2021 21:34:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C8C1447CE for ; Fri, 5 Mar 2021 21:34:28 +0100 (CET) Message-ID: Date: Fri, 5 Mar 2021 21:34:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210303115042.22061-1-f.ebner@proxmox.com> <20210303115042.22061-3-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210303115042.22061-3-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.302 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 manager 3/3] fix #2745: ui: backup: allow users to specify remove=1 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 20:35:04 -0000 On 03.03.21 12:50, Fabian Ebner wrote: > A user with Datastore.AllocateSpace, VM.Audit, VM.Backup can already remove > backups from the GUI manually, so it shouldn't be a problem if they can set > the remove flag when starting a manual backup in the GUI. > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Rebase on current master. > * Do not use the label 'Remove', because that is rather confusing, instead > use 'Prune'. > > www/manager6/window/Backup.js | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js > index 615073f3..d5b585bb 100644 > --- a/www/manager6/window/Backup.js > +++ b/www/manager6/window/Backup.js > @@ -68,6 +68,17 @@ Ext.define('PVE.window.Backup', { > name: 'mailto', > emptyText: Proxmox.Utils.noneText, > }, > + { > + xtype: 'proxmoxcheckbox', > + name: 'remove', > + checked: false, > + uncheckedValue: 0, > + fieldLabel: gettext('Prune'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Prune older backups afterwards'), > + }, > + }, I find this confusing in the case the storage has no prune settings configured and also if there's one its intransparent as one cannot really tell which one. So I'd maybe only enable (or show?) this if it can actually do something, and in that case I'd also show the current settings (they could change in theory until the job is submitted, but not the norm and still better than nothing). > ], > }); > > @@ -82,7 +93,7 @@ Ext.define('PVE.window.Backup', { > storage: storage, > vmid: me.vmid, > mode: values.mode, > - remove: 0, > + remove: values.remove, > }; > > if (values.mailto) { >