From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 983EE1FF16B for ; Thu, 12 Dec 2024 18:12:22 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0E57A1AA2; Thu, 12 Dec 2024 18:12:28 +0100 (CET) Message-ID: Date: Thu, 12 Dec 2024 18:12:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Herzig References: <20241205163332.130930-1-d.herzig@proxmox.com> <20241205163332.130930-2-d.herzig@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20241205163332.130930-2-d.herzig@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.508 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common 1/4] fix #5900: add helper function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 12/5/24 17:33, Daniel Herzig wrote: > This patch adds a small helper function to retrieve the bridge name > from the netN parameter string of a container or VM configuration. > > Signed-off-by: Daniel Herzig > --- > src/PVE/GuestHelpers.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm > index 592b4a8..c6006ba 100644 > --- a/src/PVE/GuestHelpers.pm > +++ b/src/PVE/GuestHelpers.pm > @@ -450,4 +450,15 @@ sub abort_guest_tasks { > return $aborted_tasks; > } > > +sub get_bridge { > + my $net_params = shift; > + my $param_array = [ split(/,/, $net_params) ]; > + my $bridge; > + for my $net_param (@$param_array) { > + $bridge = $net_param if ($net_param =~ /bridge\=/); > + $bridge =~ s|bridge\=|| if (defined($bridge)); > + } > + return $bridge; > +} > + > 1; net is a property string, if you want to parse it there are helpers for that in PVE::JSONSchema. For VMs as well as CTs we already have helpers for parsing the network property string defined: PVE::QemuServer::parse_net PVE::LXC::Config::parse_lxc_network _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel