From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9C9871FF168 for ; Tue, 26 Nov 2024 10:14:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 247772AE60; Tue, 26 Nov 2024 10:14:15 +0100 (CET) Message-ID: Date: Tue, 26 Nov 2024 10:14:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20241121151335.130711-1-h.laimer@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helpers.pm] Subject: Re: [pve-devel] [PATCH qemu-server v2] fix #3588: helper: consider NIC count for config-specific timeout X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11/25/24 16:15, Fiona Ebner wrote: > Am 21.11.24 um 16:13 schrieb Hannes Laimer: >> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm >> index 0afb6317..1888487e 100644 >> --- a/PVE/QemuServer/Helpers.pm >> +++ b/PVE/QemuServer/Helpers.pm >> @@ -167,6 +167,15 @@ sub config_aware_timeout { >> $timeout = 150; >> } >> >> + # Some testing showed that adding a NIC increased the start time by ~450ms >> + # consistently across different NIC models, options and already existing >> + # number of NICs. >> + # So 10x that to account for any potential system differences seemed >> + # reasonable. User reports with real-life values (20+: ~50s, 25: 45s, 17: 42s) >> + # also make this seem a good value. >> + my $nic_count = grep { /^net\d{1,2}/ } keys %{$config}; > > I'd use \d+ like in other places. > I'll change that >> + $timeout += scalar ($nic_count * 5); > > I meant using scalar() around the grep, not here ;) ohh, that does indeed make more sense, not sure why I put it here tbh :D _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel