From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15EA488814 for ; Thu, 28 Jul 2022 12:26:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B98328C9 for ; Thu, 28 Jul 2022 12:26:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 28 Jul 2022 12:26:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5F4CD41C8C for ; Thu, 28 Jul 2022 12:26:51 +0200 (CEST) Message-ID: Date: Thu, 28 Jul 2022 12:26:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, Stefan Hrdlicka References: <20220513135550.1856651-1-s.hrdlicka@proxmox.com> <20220513135550.1856651-3-s.hrdlicka@proxmox.com> From: Fiona Ebner In-Reply-To: <20220513135550.1856651-3-s.hrdlicka@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs 2/2] cifs: add options parameter (fix #2920) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 10:26:52 -0000 Am 13.05.22 um 15:55 schrieb Stefan Hrdlicka: > Signed-off-by: Stefan Hrdlicka > --- > this depends on 1/2 since this changes the documentation :) > > pve-storage-cifs.adoc | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc > index bb4b902..60775a4 100644 > --- a/pve-storage-cifs.adoc > +++ b/pve-storage-cifs.adoc > @@ -57,6 +57,10 @@ path:: > > The local mount point. Optional, defaults to `/mnt/pve//`. > > +options:: > + > +CIFS mount options (see `man mount.cifs`). Maybe add "Additional" and briefly mention that we set some options like username, vers, etc. based on the other settings? > + > .Configuration Example (`/etc/pve/storage.cfg`) > ---- > cifs: backup > @@ -64,6 +68,7 @@ cifs: backup > server 10.0.0.11 > share VMData > content backup > + options noserverino,cache=loose Reading the man page, cache=loose sounds rather dangerous! I'd rather have the example use something that can't lead to data corruption in some scenarios :S > username anna > smbversion 3 >