From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 4029E1FF187 for ; Mon, 14 Jul 2025 15:53:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1353A18873; Mon, 14 Jul 2025 15:54:25 +0200 (CEST) Message-ID: Date: Mon, 14 Jul 2025 15:53:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Christoph Heiss References: <20250714104235.2107690-1-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager/widget-toolkit 0/2] show altenative interface names in the web ui X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/14/25 15:49, Christoph Heiss wrote: > Tested the series, came across two thing: > > Given e.g. the following interface: > > 11: ens8: mtu 1500 qdisc [..] > link/ether 01:02:03:04:05:06 brd ff:ff:ff:ff:ff:ff > altname nic8 > altname enxdeadff02d073 > > and the following /etc/network/interfaces snippet: > > auto nic8 > iface nic8 inet manual > > the interface will be displayed twice in the network page. If in the > above snippet s/nic8/ens8/ is done (i.e. using the primary name), it > works correctly. > > I guess between our /e/n/i parser and the altname mapping the interface > is picked up twice, so this will need some sort of "de-duplication" in > the backend, from what I can gather. yeah i don't touch the which interfaces will be shown, so that's on the /e/n/i parser > > --- > > Further, if an interface has at least two altnames (like above), the > ordering doesn't seem stable across API requests. > > E.g. double-click on an interface, close the dialog -> the > altnames will switch around randomly in the table column. > Opening the dialog multiple times yields the same behaviour for the > altname textfield. yeah that's true, we probably want a 'sort keys' here, i'll wait until tomorrow for a v2 if there are other remarks > > On Mon Jul 14, 2025 at 12:42 PM CEST, Dominik Csapak wrote: >> This series goes on top of Stefan Hahnreich's last series[0], but it seems >> there is still some things missing from INotify (to e.g. set the altnames via >> the api), so maybe the helper I introduce in the pve-manager patch will be >> unnecessary, depending if parsing the interfaces file will already return the >> altnames. >> >> Note that the pve-manager patch depends on the widget-toolkit patch >> >> 0: https://lore.proxmox.com/pve-devel/20250709194526.560709-2-s.hanreich@proxmox.com/ >> >> proxmox-widget-toolkit: >> >> Dominik Csapak (1): >> network: optionally show alternative interface names >> >> src/node/NetworkEdit.js | 19 +++++++++++++++++++ >> src/node/NetworkView.js | 20 ++++++++++++++++++++ >> 2 files changed, 39 insertions(+) >> >> >> pve-manager: >> >> Dominik Csapak (1): >> api/ui: show/return alternative interface names >> >> PVE/API2/Network.pm | 32 ++++++++++++++++++++++++++++++-- >> www/manager6/node/Config.js | 1 + >> 2 files changed, 31 insertions(+), 2 deletions(-) >> >> >> Summary over all repositories: >> 4 files changed, 70 insertions(+), 2 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel