From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5A22B75451 for ; Wed, 13 Oct 2021 11:13:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48C40F1BD for ; Wed, 13 Oct 2021 11:13:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7BB3CF199 for ; Wed, 13 Oct 2021 11:13:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4129B45DAE for ; Wed, 13 Oct 2021 11:13:14 +0200 (CEST) To: pve-devel@lists.proxmox.com, Oguz Bektas References: <20211012133236.1533765-1-o.bektas@proxmox.com> From: Fabian Ebner Message-ID: Date: Wed, 13 Oct 2021 11:12:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211012133236.1533765-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.274 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lxc.pm] Subject: Re: [pve-devel] [PATCH container] api: clone_vm: don't include 'parent' property in clones X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2021 09:13:51 -0000 Am 12.10.21 um 15:32 schrieb Oguz Bektas: > apparently this caused a weird[0] bug... when a container with a > snapshot 'foo' was cloned, it would take 'parent: foo' from the original > container. when you add a new snapshot 'bar' to the cloned container, > and then another one 'foo', this causes the snapshots to become parents > of each other (thus not parsed correctly in the tree view of GUI nor > with 'pct listsnapshot CTID') > > [0]: https://forum.proxmox.com/threads/snapshots-of-one-lxc-disappeared.97711/ > > Signed-off-by: Oguz Bektas > --- > src/PVE/API2/LXC.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm > index 1f2f1f0..15a1926 100644 > --- a/src/PVE/API2/LXC.pm > +++ b/src/PVE/API2/LXC.pm > @@ -1515,6 +1515,7 @@ __PACKAGE__->register_method({ > delete $newconf->{snapshots}; > delete $newconf->{pending}; > delete $newconf->{template}; > + delete $newconf->{parent}; > if ($param->{hostname}) { > $newconf->{hostname} = $param->{hostname}; > } > A short note that we already do this for VMs could've been nice ;) In fact, we remove more properties there, namely also snapstate, snaptime and vmstate. Makes sense to do the same here (even if vmstate currently doesn't exist). For already affected configs (luckily backups are not affected AFAICT), we might think about adding a cleanup/safeguard against creating loops when a new snapshot is created. Something like: if any already existing snapshot (or normal config) has the new snapshot name as parent, remove that parent property. Of course only after checking that the new snapshot name does not already exist. Or maybe die and prompt for manual cleanup.