From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id B31641FF15C
for <inbox@lore.proxmox.com>; Wed, 19 Mar 2025 10:06:30 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7602E53B2;
Wed, 19 Mar 2025 10:06:19 +0100 (CET)
Message-ID: <c66737a8-3914-49cd-8773-4c3ffcb5e796@proxmox.com>
Date: Wed, 19 Mar 2025 10:05:46 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: pve-devel@lists.proxmox.com
References: <20250319085809.84343-1-m.sandoval@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20250319085809.84343-1-m.sandoval@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager] ui: tag: only set lowercased tags
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 3/19/25 09:58, Maximiliano Sandoval wrote:
> At the moment, the color of the preview tag won't match the final tag
> once it is added if the tag contained uppercase letters. With this patch
> the color in the tag being created will match the color of the final tag
> added to a guest.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> www/manager6/form/Tag.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js
> index 6b1d6aa55..399644899 100644
> --- a/www/manager6/form/Tag.js
> +++ b/www/manager6/form/Tag.js
> @@ -181,6 +181,7 @@ Ext.define('Proxmox.form.Tag', {
> setTag: function(tag) {
> let me = this;
> let oldtag = me.tag;
> + tag = tag.toLowerCase();
> me.tag = tag;
>
> clearTimeout(me.colorTimeout);
this would only be valid if we could not have case sensitive tags,
but this is configurable in the datacenter options. So what we want here
is to make behavior dependent on the case-sensitivity setting.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel