From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5D7851FF16B for ; Tue, 15 Jul 2025 13:27:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E39C63A071; Tue, 15 Jul 2025 13:28:05 +0200 (CEST) Message-ID: Date: Tue, 15 Jul 2025 13:28:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Shan Shaji References: <20250710084446.8247-1-s.shaji@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <20250710084446.8247-1-s.shaji@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_MSPIKE_H2 0.001 Average reputation (+2) RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: ios: update bundle identifier and display name X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 7/10/25 10:44, Shan Shaji wrote: > For iOS, the bundle identifier and display name were incorrect. The > issue was fixed by updating the bundle identifier to > `com.proxmox.proxmox-ve-companion` and the display name to "Proxmox VE". ok i understand the name change, but what exactly was wrong with 'com.proxmox.pveFlutterFrontend' ? are there any guidelines or rules in the app store that would prevent us from using that? I'm not saying we can't change this, but it would be good to record the reason at least... Aside from that the patch looks good to me: Reviewed-by: Dominik Csapak side note: I'd like to have a testbed where i could test ios changes before i start applying things... > > A new `APP_DISPLAY_NAME` variable was defined in the build settings > and is used for both `CFBundleName` [0] and `CFBundleDisplayName` [1]. > > The name was not set to "Proxmox VE Companion" because iOS will > truncate long names on the home screen due to character limits. When > the above name was set, the name was appearing as "ProxmoxVECo...". > > - [0] https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundlename > - [1] https://developer.apple.com/documentation/bundleresources/information-property-list/cfbundledisplayname > > Signed-off-by: Shan Shaji > --- > > All changes are done using Xcode, that's why there are changes > inside the Xcode project file [0] (.pbxproj). The new variable was added > using the build settings [1]. The .plist [2] file was updated using > the info pain under target. > > - [0] https://developer.apple.com/library/archive/featuredarticles/XcodeConcepts/Concept-Projects.html > - [1] https://help.apple.com/xcode/mac/current/#/dev382dac089 > - [2] https://help.apple.com/xcode/mac/current/#/dev37c2f42ff > > ios/Runner.xcodeproj/project.pbxproj | 9 ++++++--- > ios/Runner/Info.plist | 4 ++-- > 2 files changed, 8 insertions(+), 5 deletions(-) > > diff --git a/ios/Runner.xcodeproj/project.pbxproj b/ios/Runner.xcodeproj/project.pbxproj > index fa595a2..102a964 100644 > --- a/ios/Runner.xcodeproj/project.pbxproj > +++ b/ios/Runner.xcodeproj/project.pbxproj > @@ -359,6 +359,7 @@ > isa = XCBuildConfiguration; > baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */; > buildSettings = { > + APP_DISPLAY_NAME = "Proxmox VE"; > ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; > CLANG_ENABLE_MODULES = YES; > CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; > @@ -368,7 +369,7 @@ > "$(inherited)", > "@executable_path/Frameworks", > ); > - PRODUCT_BUNDLE_IDENTIFIER = com.proxmox.app.pveFlutterFrontend; > + PRODUCT_BUNDLE_IDENTIFIER = "com.proxmox.proxmox-ve-companion"; > PRODUCT_NAME = "$(TARGET_NAME)"; > SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h"; > SWIFT_VERSION = 5.0; > @@ -538,6 +539,7 @@ > isa = XCBuildConfiguration; > baseConfigurationReference = 9740EEB21CF90195004384FC /* Debug.xcconfig */; > buildSettings = { > + APP_DISPLAY_NAME = "Proxmox VE"; > ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; > CLANG_ENABLE_MODULES = YES; > CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; > @@ -547,7 +549,7 @@ > "$(inherited)", > "@executable_path/Frameworks", > ); > - PRODUCT_BUNDLE_IDENTIFIER = com.proxmox.app.pveFlutterFrontend; > + PRODUCT_BUNDLE_IDENTIFIER = "com.proxmox.proxmox-ve-companion"; > PRODUCT_NAME = "$(TARGET_NAME)"; > SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h"; > SWIFT_OPTIMIZATION_LEVEL = "-Onone"; > @@ -560,6 +562,7 @@ > isa = XCBuildConfiguration; > baseConfigurationReference = 7AFA3C8E1D35360C0083082E /* Release.xcconfig */; > buildSettings = { > + APP_DISPLAY_NAME = "Proxmox VE"; > ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; > CLANG_ENABLE_MODULES = YES; > CURRENT_PROJECT_VERSION = "$(FLUTTER_BUILD_NUMBER)"; > @@ -569,7 +572,7 @@ > "$(inherited)", > "@executable_path/Frameworks", > ); > - PRODUCT_BUNDLE_IDENTIFIER = com.proxmox.app.pveFlutterFrontend; > + PRODUCT_BUNDLE_IDENTIFIER = "com.proxmox.proxmox-ve-companion"; > PRODUCT_NAME = "$(TARGET_NAME)"; > SWIFT_OBJC_BRIDGING_HEADER = "Runner/Runner-Bridging-Header.h"; > SWIFT_VERSION = 5.0; > diff --git a/ios/Runner/Info.plist b/ios/Runner/Info.plist > index ef3f061..1608de0 100644 > --- a/ios/Runner/Info.plist > +++ b/ios/Runner/Info.plist > @@ -5,7 +5,7 @@ > CFBundleDevelopmentRegion > $(DEVELOPMENT_LANGUAGE) > CFBundleDisplayName > - Pve Flutter Frontend > + $(APP_DISPLAY_NAME) > CFBundleExecutable > $(EXECUTABLE_NAME) > CFBundleIdentifier > @@ -13,7 +13,7 @@ > CFBundleInfoDictionaryVersion > 6.0 > CFBundleName > - pve_flutter_frontend > + $(APP_DISPLAY_NAME) > CFBundlePackageType > APPL > CFBundleShortVersionString _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel