From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 83CCD70D68 for ; Thu, 30 Sep 2021 18:07:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 81A1722790 for ; Thu, 30 Sep 2021 18:07:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9B71E22782 for ; Thu, 30 Sep 2021 18:07:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 70A3944C53 for ; Thu, 30 Sep 2021 18:07:13 +0200 (CEST) Message-ID: Date: Thu, 30 Sep 2021 18:06:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210928114001.164081-1-f.ebner@proxmox.com> <20210928114001.164081-2-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210928114001.164081-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.232 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.pm, directory.pm, lvmthin.pm, lvm.pm] Subject: [pve-devel] applied: [PATCH storage 01/10] api: disks: create: re-check disk after fork/lock X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Sep 2021 16:07:14 -0000 On 28.09.21 13:39, Fabian Ebner wrote: > Because then it might not be unused anymore. If there really is a > race, this prevents e.g. sgdisk creating a partition on a device > already in use by LVM or LVM destroying a partitioned device. > > For ZFS, also get the latest udev info once inside the worker. > > Signed-off-by: Fabian Ebner > --- > PVE/API2/Disks/Directory.pm | 2 ++ > PVE/API2/Disks/LVM.pm | 2 ++ > PVE/API2/Disks/LVMThin.pm | 2 ++ > PVE/API2/Disks/ZFS.pm | 10 +++++++--- > 4 files changed, 13 insertions(+), 3 deletions(-) > > applied, thanks!