From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D3052960E5 for ; Mon, 15 Apr 2024 11:27:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB5176357 for ; Mon, 15 Apr 2024 11:27:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 15 Apr 2024 11:27:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 28B6844A81 for ; Mon, 15 Apr 2024 11:27:04 +0200 (CEST) Message-ID: Date: Mon, 15 Apr 2024 11:27:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion , Maximiliano Sandoval References: <20231123160902.282661-1-l.wagner@proxmox.com> <34eb2ab5-4022-4630-9baf-d5466ba32c0c@proxmox.com> Content-Language: de-AT, en-US From: Lukas Wagner In-Reply-To: <34eb2ab5-4022-4630-9baf-d5466ba32c0c@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2024 09:27:05 -0000 On 2024-04-11 09:44, Thomas Lamprecht wrote: >> Tested both commits, they do what they promise. >> >>> + let notificationSystemHint = Ext.create({ >>> + xtype: 'displayfield', >>> + padding: '0 0 0 5', >>> + userCls: 'pmx-hint', >>> + hidden: true, >>> + value: gettext('No email configured, the notification system will be used'), >>> + viewModel, >>> + bind: { >>> + hidden: '{!hintTextVisible}', >> >> I think the `pmx-hint` being displayed as yellow suggests it is a >> warning/error rather than a hint. I wonder if there is a better >> approach, as this is certainly not a warning. > > Yeah, the hint is even often used as warning, having something more like a > "notice" or well, actual "hint" level, that isn't as flashy, might be a > good idea in the long run.. > > For now, we could also set a 'Hint' label and then add the pmx-hint class only > to the labelClsExtra config? > > But I'm fine with this as is if you, Lukas, think that it's warranted (and > maybe even not showed that often in practice anyway). Actually this is visible when creating new backup jobs, because 'Notification mode' is set to 'Default (auto)' and there is no email entered. So yeah, a more gentle hint would be better. That being said, I'd like to get this merged ASAP to resolve pontential for confusion for our users[1]. I would suggest to merge the variant with 'pmx-hint' (I'll send a v2 though, because I fixed a minor issue just now when reevaluating this) and then revisit this soonish to introduce a more hinty, less warning CSS class. There are other places where that one could be useful (e.g. second page of the same dialog - Retention, or Rentention settings for storage plugins), so we could fix them all in one go in a followup. [1] https://forum.proxmox.com/threads/pve-sending-email-notifications-on-successful-backup-jobs.136768/post-635769 -- - Lukas