From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6BAFF6AEBD for ; Wed, 17 Feb 2021 12:42:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 596C121719 for ; Wed, 17 Feb 2021 12:42:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7C9962170F for ; Wed, 17 Feb 2021 12:42:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 41D54461C0 for ; Wed, 17 Feb 2021 12:42:05 +0100 (CET) To: pve-devel@lists.proxmox.com References: <20210215122502.23854-1-f.ebner@proxmox.com> <27e9623d-8765-010a-3015-a13d34db6fec@proxmox.com> From: Fabian Ebner Message-ID: Date: Wed, 17 Feb 2021 12:42:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.401 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jsonschema.pm, proxmox.com, common.pm] Subject: Re: [pve-devel] [PATCH-SERIES v2] loosen up mailto regex for backwards compatibility X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 11:42:36 -0000 On 17.02.21 11:35, Fabian Ebner wrote: > On 17.02.21 10:52, Dominik Csapak wrote: >> LGTM, nothing obvious that is wrong >> one small thing though, after this patch i cannot >> have an @ in the local part of an email anymore, though >> i do not think that people actually use that? >> >> e.g. foo@bar@example.com does not work anymore >> > > Thanks for the review and for catching that! I'll send a follow-up (or > does this warrant a v3?) including '@' in the local part, and check that > other users of the 'email' format are not confused by that in some way. > After a bit of discussion, I decided to not send that follow-up, because '@' is technically only valid in quoted strings (which we didn't/don't support here) and AFAICT we used the same 'email' format from pve-common in some parts of PMG without noticeable complaints. >> Other than that, i tested it and worked as advertised >> >> Reviewed-By: Dominik Csapak >> >> On 2/15/21 13:24, Fabian Ebner wrote: >>> especially regarding the whitespace-agnostic behavior. And while >>> we're at it, >>> also use the more complete email regex from pve-common. >>> >>> Changes from v1: >>>      * re-use the email regex from pve-common >>>      * improve printing out mailto parameters to the cron file >>> >>> >>> common: >>> >>> Fabian Ebner (2): >>>    sendmail: use more complete email regex and shellquote >>>    register email-or-username format >>> >>>   src/PVE/JSONSchema.pm | 14 +++++++++++++- >>>   src/PVE/Tools.pm      | 17 ++++++++++++----- >>>   2 files changed, 25 insertions(+), 6 deletions(-) >>> >>> >>> guest-common: >>> >>> Fabian Ebner (3): >>>    vzdump: command line: refactor handling prune-backups >>>    vzdump: command line: make sure mailto is comma-separated >>>    vzdump: mailto: use email-or-username-list format >>> >>>   PVE/VZDump/Common.pm | 14 +++++--------- >>>   1 file changed, 5 insertions(+), 9 deletions(-) >>> >>> >>> manager: >>> >>> Fabian Ebner (3): >>>    vzdump: refactor parsing mailto so it can be mocked >>>    test: vzdump: add tests for mailto >>>    test: vzdump: rename vzdump_new_retention_test.pl to >>>      vzdump_new_test.pl >>> >>>   PVE/API2/VZDump.pm                            |  11 +- >>>   PVE/VZDump.pm                                 |  21 +++ >>>   test/Makefile                                 |   8 +- >>>   ...w_retention_test.pl => vzdump_new_test.pl} | 174 +++++++++++++++++- >>>   4 files changed, 198 insertions(+), 16 deletions(-) >>>   rename test/{vzdump_new_retention_test.pl => vzdump_new_test.pl} (74%) >>> >> >> >> >> _______________________________________________ >> pve-devel mailing list >> pve-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel >> >> > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel