From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 138511FF13C for ; Thu, 05 Mar 2026 08:03:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EA6BA1B4BE; Thu, 5 Mar 2026 08:04:42 +0100 (CET) Message-ID: Date: Thu, 5 Mar 2026 08:04:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC proxmox 04/22] firewall-api-types: add logging types To: Stefan Hanreich , pve-devel@lists.proxmox.com References: <20260216104401.3959270-1-dietmar@proxmox.com> <20260216104401.3959270-5-dietmar@proxmox.com> <1687c468-ffd8-459c-ae20-8efd564b908a@proxmox.com> Content-Language: en-US From: Dietmar Maurer In-Reply-To: <1687c468-ffd8-459c-ae20-8efd564b908a@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1772694223290 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.340 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QWUAH7YW4JRKFPZMJGXELTTHIVEEBZOT X-Message-ID-Hash: QWUAH7YW4JRKFPZMJGXELTTHIVEEBZOT X-MailFrom: dietmar@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: >> +serde_plain::derive_deserialize_from_fromstr!(FirewallPacketRate, "valid packet rate"); >> +serde_plain::derive_serialize_from_display!(FirewallPacketRate); > we have similar macros in proxmox-serde as well [1]. Would potentially > save an external dependency? applies to all instances in this patch > series ofc. I think we should remove those macros, and use serde_plain instead.