From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EE6DC620AD for <pve-devel@lists.proxmox.com>; Mon, 23 Nov 2020 07:12:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF03B23876 for <pve-devel@lists.proxmox.com>; Mon, 23 Nov 2020 07:11:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 70BBA2386C for <pve-devel@lists.proxmox.com>; Mon, 23 Nov 2020 07:11:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3BD2543E6E for <pve-devel@lists.proxmox.com>; Mon, 23 Nov 2020 07:11:39 +0100 (CET) To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20201120141228.24005-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> Message-ID: <c425ed14-9a3b-6b40-82ca-3b25d0ec7260@proxmox.com> Date: Mon, 23 Nov 2020 07:11:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201120141228.24005-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [metricserverconfig.pm, cluster.pm] Subject: [pve-devel] applied: [PATCH manager v2 0/2] add UI support for editing metric servers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Mon, 23 Nov 2020 06:12:10 -0000 On 20.11.20 15:12, Dominik Csapak wrote: > Adds the typical sectionconfig api entry points, as well as a basic > CRUD ui under Datacenter -> Metric Server >=20 > the next step is to adapt the documentation to no refer to editing the > config anymore, adding some more useful information, as well > as adding a onlinehelp link to the ui >=20 > changes from v1: > * integrated thomas feedback, aside from using createSchema for return = values > (i'll look at it soon) > * ran eslint -f over dc/MetricServerView.js >=20 > Dominik Csapak (2): > api2/cluster: add 'metricserver' api endpoints > ui: add MetricServerView to Datacenter >=20 > PVE/API2/Cluster.pm | 7 + > PVE/API2/Cluster/Makefile | 1 + > PVE/API2/Cluster/MetricServerConfig.pm | 228 ++++++++++++++ > www/manager6/Makefile | 1 + > www/manager6/dc/Config.js | 6 + > www/manager6/dc/MetricServerView.js | 397 +++++++++++++++++++++++++= > 6 files changed, 640 insertions(+) > create mode 100644 PVE/API2/Cluster/MetricServerConfig.pm > create mode 100644 www/manager6/dc/MetricServerView.js >=20 applied, thanks! I did followups for the remaining comments I had on v1 t= hat went lost.