From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 5E6861FF09C for ; Mon, 02 Nov 2026 11:01:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 56B79216C8; Mon, 02 Nov 2026 11:01:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793613652; x=1794218452; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T1ixasjQQ34pE2Mdg8oHHsuNRp0kRpxVQk+hpUJv2NM=; b=YKf84M1pCJrjmY21QxYdLuJFH4J9FAZ0TEm72cOvNlgiRIH22biPRtpVTVREyUplQ6 ae0rimAndsEDW2yvqApZhTuWwaCdoHfj8DcXTL7KHNmESFVOYTjtw+FgSI8v3WWrRTBM kwb7UrrSUAGQ6vN8Yraxayuv6+/fgtre9vxSwIr0ICTFYfC9ftXyJDYY/VlcKaUy2aUd 0AddvGc7YpUbAAVnkftmy7rdi/js38Zct/EanS3BFhRH1sUYpItopx+RsDe2GRO5kSrE CKxvUSvFAJLoqAqCzjMwuYHy6uxPTOHhpshmw95+B5pg/dXSY6g45LMO8TKEOl1rcvif ocSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793613652; x=1794218452; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T1ixasjQQ34pE2Mdg8oHHsuNRp0kRpxVQk+hpUJv2NM=; b=xgqfldU5EGeEn1quf7qRcgtmuiydpYCwu5g7lok3jYr60Z1VLR2Hw7JpDl4pjeBxFZ lKk6R7MZr9c8m4HsuNfim8416ryjLl+qZ/I7TU3hgMOdgAjflh/DTr9Eu8SLs7dk/s28 OFY2UH0LvlqsdpxYh0ZJPF1f9Pe9+/WwM90+ZWQsnyhFi4d3AyVgmLZomX3c0yiQE8sm 68ZGEtcbuHbfQakYLoh4iee0Wu9N+FnDmFhZeHNTWD8qCwWs/LAc6FwzuQzky+4/Nl/W PQOe/abSWR7CjcgrHodoJnYGkpINRJwgqot8WVX7PCCtnj5Ay2JtmKR2/NVjnziBCdOJ o7dw== X-Forwarded-Encrypted: i=1; AKwUvBxKgjbNagwJXhy9KuUdjdZVp5ikRyoQA+oEKnVdHaOl3w2pBrCh1g6TO1T+2XylnOmQlXUObIshUi8=@lists.proxmox.com X-Gm-Message-State: APuU4Z/9foR0LOI+Y07pHzKmo8wbmue5ENFx/KMjl/0SjFSCm9BeH3bO Ul1+FURwg/ACIj529SUwVUUIVDghBsvryX/zkzEG3/csLilhgf2al2A4 X-Gm-Gg: AYBFou0mdEZ5OvSDVj/e3a7JWpgiCgK41sISyWNaiSattsL2SACha2BDv+PL4LqII/3 BWLBVp7AQHgHCAnK+v2qZP7pkrluY817Fhj8D1BhkhZzH77CwBqpo2wjd+JBi/ZIZAoq4pJR9L4 SrZqChFO5DnGTaduRdteDD+pLapFmvLB/bPHHHYePUzUVmTfa3iFGI0JADBre033QxcyUmRfHmf PWzu3j8+gvHfRPmjmrmAOQsCDMSu5mUmFUaFx4Eyb3LX/XvkDzMZhXzkD7SbNBsB+Rtf4J38nz1 n3LWuyPGmWxb29hoeJ9GF808oTusT7VWYLUc6hyeJ67Oj6TpllxzoS0B66gibmqwsX+PXEZNVPj kI4zTMQYprlptKF/xDwW8z3Ule+kVXOX9aXrdTTcqlvO687pJdsK50OvJ50jOyftVFCSdSwOYof ffhR2vXKoig+0bP+rVlgPumAy/ga70nJVhbHdeOo6ka7jX3ksxptx6QbLaeJ/XmM4LO+aSkdFXM JBU59AJjfHxr4EWOeg1sbx10oOsRG12ZwtfkL3JhjLwXdA69seeOUIq9ZdxbfgcTH39RrP8oamC uWkMP2FVdJjujYXfOjMF+VUQjbxlL9vgias= X-Received: by 2002:a17:903:388b:b0:2df:9d04:403b with SMTP id d9443c01a7336-2eb364b5c40mr85022665ad.32.1793613652116; Mon, 02 Nov 2026 02:00:52 -0800 (PST) Message-ID: Date: Mon, 2 Nov 2026 18:00:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server/docs/manager v3 0/3] add pvpanic device support To: Dominik Csapak , pve-devel@lists.proxmox.com References: <20261009065813.109006-1-wukaiyang@loongfans.cn> Content-Language: en-US From: Kaiyang Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_ENVFROM_END_DIGIT 1 Envelope-from freemail username ends in digit FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GMML4PQVW2MWPXUYUWK6VKZJOJBE54XO X-Message-ID-Hash: GMML4PQVW2MWPXUYUWK6VKZJOJBE54XO X-MailFrom: wukaiyang2003@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Kaiyang Wu X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the suggestions! Superseded by https://lore.proxmox.com/pve-devel/20261102095525.1635251-1-wukaiyang@loongfans.cn/ On 2026-10-30 22:06, Dominik Csapak wrote: > thanks for the updated series! > > i answer on the individual patches for some details. > > What would also be nice in the future would be a qmevent patch that > listens for the panic event and maybe send out a notification via the > notification stack (or at least log it to the syslog). > > This can be done later though, so nothing needed for this series. > > On 10/9/26 8:58 AM, Kaiyang Wu wrote: >> This patchset adds pvpanic device support to QEMU virtual machines to >> provide extra virtual machine status (guest-panicked) when virtual >> machines panic [0]. >> >> [0]: https://www.qemu.org/docs/master/specs/pvpanic.html >> >> v1: https://lore.proxmox.com/pve-devel/20260827103529.393388-1- >> wukaiyang@loongfans.cn/ >> v2: https://lore.proxmox.com/pve-devel/20260914092015.125780-1- >> wukaiyang@loongfans.cn/ >> >> Changes v1 -> v2: >> - Remove the pvpanic ISA device support to simplify the code >> - Move the pvpanic setting from Hardware to Options >> - Restart a HA-managed VM when it panics to restore the "started" state >> >> Changes v2 -> v3: >> - Allow to set panic action. The HA stack automatically restarts a >> panicked VM >>    when the VM exits using the 'exit-failure' panic action >> >> >> qemu-server: >> >> Kaiyang Wu (1): >>    qemuserver: add pvpanic device >> >>   src/PVE/API2/Qemu.pm      |  1 + >>   src/PVE/QemuServer.pm     | 42 +++++++++++++++++++++++++++++++++++++++ >>   src/PVE/QemuServer/PCI.pm |  1 + >>   3 files changed, 44 insertions(+) >> >> >> docs: >> >> Kaiyang Wu (1): >>    qm: add document section for the pvpanic device >> >>   qm.adoc | 38 ++++++++++++++++++++++++++++++++++++++ >>   1 file changed, 38 insertions(+) >> >> >> manager: >> >> Kaiyang Wu (1): >>    ui: qemu: add pvpanic device support >> >>   www/manager6/Makefile                |  1 + >>   www/manager6/Utils.js                | 18 +++++++++ >>   www/manager6/form/PvpanicSelector.js | 56 ++++++++++++++++++++++++++++ >>   www/manager6/qemu/Options.js         | 16 ++++++++ >>   4 files changed, 91 insertions(+) >>   create mode 100644 www/manager6/form/PvpanicSelector.js >> >