From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8EBCD8BEC9 for ; Fri, 28 Oct 2022 10:59:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6A85318A69 for ; Fri, 28 Oct 2022 10:59:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 28 Oct 2022 10:59:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD70244C65 for ; Fri, 28 Oct 2022 10:59:19 +0200 (CEST) Message-ID: Date: Fri, 28 Oct 2022 10:59:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20221028080946.29238-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221028080946.29238-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH v3 qemu] init: daemonize: defuse PID file resolve error X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2022 08:59:20 -0000 On 28/10/2022 10:09, Fiona Ebner wrote: > When proxmox-file-restore invokes QEMU, the PID file is a (temporary) > file that's already unlinked, so resolving the absolute path here > failed. > > It should not be a critical error when the PID file unlink handler > can't be registered, because the path can't be resolved for whatever > reason. If the file is already gone from QEMU's perspective (i.e. > errno is ENOENT), silently ignore the error. Otherwise, print a > warning. > > Reported-by: Dominik Csapak > Suggested-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- > > Changes from v2: > * Be quiet when error is ENOENT. > > softmmu/vl.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > applied, thanks!