From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 101C963526 for ; Wed, 10 Feb 2021 08:42:24 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 04FEFD0B9 for ; Wed, 10 Feb 2021 08:42:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8DA4ED0AC for ; Wed, 10 Feb 2021 08:42:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4F9F141A2D for ; Wed, 10 Feb 2021 08:42:23 +0100 (CET) Message-ID: Date: Wed, 10 Feb 2021 08:42:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:86.0) Gecko/20100101 Thunderbird/86.0 Content-Language: en-US From: Thomas Lamprecht To: Proxmox VE development discussion , Dietmar Maurer , Aaron Lauterer Reply-To: Proxmox VE development discussion References: <20210209154531.11093-1-a.lauterer@proxmox.com> <738854076.2385.1612894919694@webmail.proxmox.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.071 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.265 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 ha-manager] ha-simulator: add xauth dependency X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Feb 2021 07:42:24 -0000 On 10.02.21 08:29, Thomas Lamprecht wrote: > On 09.02.21 19:21, Dietmar Maurer wrote: >> On 09.02.21 16:45, Aaron Lauterer wrote: >>> When installing the ha-simulator on a PVE node to start it via ssh with >>> x11 forwarding, the xauth package helps to avoid `Unable to init server: >>> Could not connect: Connection refused` errors. >> >> This is true for anything. X11 forwarding simply works that way. So I am quite unsure if we should add xauth here...> > Or is this a common practice (I am unaware of)? > > Not really, but there are not much programs which are primarily run over > SSH forwarding I know either. > > If one really wants an active warning one could do a check like: > > defined($ENV{'SSH_CONNECTION'}) && !(-x /usr/bin/xauth || -x /bin/xauth) > > A bit crude but could work, and could be used to print out a early warning. After short talk with Dietmar we came to the conclusion that this is far harder to tell and neither configuring a dependency to xauth nor checking if it's exist at runtime really guarantees anything and is not really a hard coded must (you can allow unauthenticated forwarding where xauth is not required). At least `/etc/ssh/sshd_config` must also be configured correctly. I'd add the latter to my proposed wording in the docs patch, IMO there's really the best place to handle this.