From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2C44F1FF0E1 for ; Mon, 27 Jul 2026 17:19:04 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DA0612143B; Mon, 27 Jul 2026 17:19:03 +0200 (CEST) Message-ID: Date: Mon, 27 Jul 2026 17:18:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH edk2-firmware/qemu-server/manager 0/4] ovmf: support pre-enrolled-keys for ARM EFI disks To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260520142044.502304-1-f.ebner@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785165470793 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.202 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: EX45RQEV7KP3FFCIDO4F7X4KF7M4X27U X-Message-ID-Hash: EX45RQEV7KP3FFCIDO4F7X4KF7M4X27U X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 22.07.26 um 2:42 PM schrieb Lukas Sichert: > On 2026-05-20 16:20, Fiona Ebner wrote: > >> Have the firmware package for ARM ship the secureboot-enabled CODE >> image. The VARS image with the pre-enrolled-keys was already shipped. >> >> Let qemu-server actually honor the pre-enrolled-keys setting and use >> those images when requested. >> >> Finally, a small UX improvment to make the task warning when the >> firmware package is outdated visible in the UI. >> >> Might be nice to have soonish after the next point release since ARM >> support was generally improved with that release. > > > I tested this by building pve-edk2-firmware on an x86 machine and the > qemu-server and pve-manager packages on an ARM machine, then installing > all packages on that ARM machine. > > Before applying the patch, the following warning was printed in the task > log: > > WARN: EFI disk without 'ms-cert=2023k' option, suggesting that not all > UEFI 2023 certificates from Microsoft are enrolled yet. > > After applying the patch, the warning disappeared and the EFI disk had > the ms-cert=2023k option. Inside the VM, I verified the result using: > 'mokutil --sb-state', which returned 'SecureBoot enabled'. > > One minor issue: > I do not know whether this is intentional, but after applying only the > first patch in pve-edk2-firmware, make deb fails. After applying the > second patch as well, it succeeds. No, it's not intentional. Including error messages in such cases is helpful ;) But no need anymore. I reproduced the issue and it was the hunk for pve-edk2-firmware-aarch64.install, which should already be part of the first patch. I'll send a v2 with that. > > This fixes the issue for me, so please consider: > > Tested-by: Lukas Sichert > Thanks for testing!