From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <n.ullreich@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E7A0DFD6B for <pve-devel@lists.proxmox.com>; Tue, 25 Jul 2023 10:00:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C699116D92 for <pve-devel@lists.proxmox.com>; Tue, 25 Jul 2023 10:00:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Tue, 25 Jul 2023 10:00:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0BE4043EC5 for <pve-devel@lists.proxmox.com>; Tue, 25 Jul 2023 10:00:18 +0200 (CEST) Message-ID: <c08c09dc-a017-48cb-100c-b3eaac335ed4@proxmox.com> Date: Tue, 25 Jul 2023 10:00:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20230721122314.80427-1-n.ullreich@proxmox.com> From: Noel Ullreich <n.ullreich@proxmox.com> In-Reply-To: <20230721122314.80427-1-n.ullreich@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.103 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.091 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [cephfsplugin.pm, nfsplugin.pm, glusterfsplugin.pm, storage.pm, dirplugin.pm, plugin.pm, cifsplugin.pm] Subject: Re: [pve-devel] [PATCH pve-storage v4; pve-manager 0/4] fix #623: show isos/vztmpl/snippets in subdirs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 25 Jul 2023 08:00:18 -0000 Forgot to add to the changelog that symlinked files now also show the size of the file not of the symlink On 21-07-2023 14:23, Noel Ullreich wrote: > This patch fixes #623, allowing isos/vztmpl/snippets in subdirectories. > This feature is opt-in and can be set from the API, web interface or > with `pvesm`. > > changes from v3: > * moved regex that is often used into variables > * enabled going through symlinked directories as well. > NB: there is no logic in this patch that looks for cycles, (so a symlink > to the directory it is in will recurse). This is not a security concern > since it can only recurse as many times as the depth has been set to, it > might however lead to isos/templates/etc appearing multiple times with > cycles in their paths. > Imo, while it is ugly, it is an edgecase of a niche feature that > doesn't break anything, so it's ok. > * changed name of parameter from subdir-depth to scan-depth > > Noel Ullreich (3): > recursively go through subdirs to find files > add `scan-depth` option to filesystems > update test for recursive subdir search > > src/PVE/Storage.pm | 11 +++++ > src/PVE/Storage/CIFSPlugin.pm | 1 + > src/PVE/Storage/CephFSPlugin.pm | 1 + > src/PVE/Storage/DirPlugin.pm | 1 + > src/PVE/Storage/GlusterfsPlugin.pm | 1 + > src/PVE/Storage/NFSPlugin.pm | 1 + > src/PVE/Storage/Plugin.pm | 61 ++++++++++++++++++--------- > src/test/filesystem_path_test.pm | 18 ++++++++ > src/test/list_volumes_test.pm | 68 ++++++++++++++++++++++++++++++ > src/test/parse_volname_test.pm | 40 ++++++++++++++++++ > 10 files changed, 182 insertions(+), 21 deletions(-) > > Noel Ullreich (1): > ui: add field to set subdir-depth in web interface > > www/manager6/storage/Base.js | 11 +++++++++++ > 1 file changed, 11 insertions(+) > >