From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3659CD48B for ; Wed, 30 Nov 2022 16:22:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0B350206B9 for ; Wed, 30 Nov 2022 16:22:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 30 Nov 2022 16:22:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 73FB2440C4 for ; Wed, 30 Nov 2022 16:22:51 +0100 (CET) Message-ID: Date: Wed, 30 Nov 2022 16:22:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Content-Language: en-GB To: Proxmox VE development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= References: <20221129120926.1241594-1-f.gruenbichler@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221129120926.1241594-1-f.gruenbichler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH qemu-server] fix #4372: fix vm_resume migration callback X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2022 15:22:53 -0000 Am 29/11/2022 um 13:09 schrieb Fabian Gr=C3=BCnbichler: > the fix for the recently introduced requirement of loading the VM confi= g while > migrating was incomplete, since the vmlist node value could already be = out of > date by the time load_config is called. >=20 > extend the fallback behaviour even further, by doing the following sequ= ence: > - try regular load_config (likely case, rename already fully processed)= > - if it fails, get node from vmlist, and load_config using that > - it that fails, invalidate the PVE::Cluster cache, retry regular load_= config >=20 > Signed-off-by: Fabian Gr=C3=BCnbichler > --- >=20 > Notes: > an alternative approach would be to do the fallback load first, and= if that > fails do the target node load. it has the downside of doing two loa= ds in the > "good"/likely case where the rename is processed before the resume = call, while > making the unlikely case (fallback needed) cheaper. >=20 > PVE/QemuServer.pm | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) >=20 > applied, thanks!