From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DB44764903 for ; Fri, 28 Jan 2022 12:23:06 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D924D2E01F for ; Fri, 28 Jan 2022 12:23:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 705632E014 for ; Fri, 28 Jan 2022 12:23:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4B42D4180A for ; Fri, 28 Jan 2022 12:23:06 +0100 (CET) Message-ID: Date: Fri, 28 Jan 2022 12:23:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Aaron Lauterer , pve-devel@lists.proxmox.com References: <20220126101844.558040-1-a.lauterer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220126101844.558040-1-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.138 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied-series: [PATCH v2 manager 1/3] ui: rbd: cephfs: add keyring/secret field for external clusters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 11:23:06 -0000 Am 26.01.22 um 11:18 schrieb Aaron Lauterer: > Manual switching of xtype because binding 'hidden' does not work with > pmxDisplayEditField. > > Signed-off-by: Aaron Lauterer > --- > changes: added spaces in front of `?` operator that were missed. > > > From previous iteration for this patch: > > Reviewed-by: Fabian Ebner > Tested-by: Fabian Ebner > > www/manager6/storage/CephFSEdit.js | 39 ++++++++++++++++++++---------- > www/manager6/storage/RBDEdit.js | 11 +++++++++ > 2 files changed, 37 insertions(+), 13 deletions(-) > thanks! Added two small followups after a brief discussion with Thomas, namely using gettext('Secret Key') for the field label for CephFS and making the "is done automatically for local cluster" more obvious in the docs. Also added the missing f in the second commit title again ;)