From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BC5411FF14C for ; Fri, 12 Jun 2026 08:52:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DA0129610; Fri, 12 Jun 2026 08:52:32 +0200 (CEST) Message-ID: Date: Thu, 11 Jun 2026 16:40:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH qemu-server] api: create: check VM.PowerMgmt on the pool too To: Maximiliano Sandoval , pve-devel@lists.proxmox.com References: <20260611142427.495288-1-m.sandoval@proxmox.com> Content-Language: en-US From: Jonas Theisen In-Reply-To: <20260611142427.495288-1-m.sandoval@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1781188756240 X-SPAM-LEVEL: Spam detection results: 0 BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record X-MailFrom: j.theisen@proxmox.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation Message-ID-Hash: CF7VXFAPP6DYDQFQUZ6LSIO3MM56Y7GU X-Message-ID-Hash: CF7VXFAPP6DYDQFQUZ6LSIO3MM56Y7GU X-Mailman-Approved-At: Fri, 12 Jun 2026 08:52:29 +0200 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 6/11/26 16:24, Maximiliano Sandoval wrote: > If a VM is part of a resource pool, it is possible to start it with the > permission either in /pool or in /vm. > > The upfront check done when creating a VM with --start=1 is extended > accordingly to look for the permission on the resource pool if > appropriate. > > Fixes: 5086f472 ("api: create: check VM.PowerMgmt up front when starting after create") > Signed-off-by: Maximiliano Sandoval > --- Tested the patch in the context of enterprise ticket #8475434 on my local test setup. Fixed the mentioned issue. -- Tested-by: Jonas Theisen