From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 65234A0288 for ; Wed, 8 Nov 2023 10:05:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3FE7C4267 for ; Wed, 8 Nov 2023 10:05:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 8 Nov 2023 10:05:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 705D9470A4 for ; Wed, 8 Nov 2023 10:05:17 +0100 (CET) Date: Wed, 8 Nov 2023 10:05:16 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: References: <20231107122102.732841-1-c.heiss@proxmox.com> <2ef3d98e-f72b-4231-a500-0cd2743c5f7f@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ef3d98e-f72b-4231-a500-0cd2743c5f7f@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] applied: [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2023 09:05:18 -0000 On Tue, Nov 07, 2023 at 04:50:31PM +0100, Thomas Lamprecht wrote: > > Am 07/11/2023 um 13:20 schrieb Christoph Heiss: > > run env: remove debug print > > install: use correct variable names in zfs_setup_module_conf() > > proxinstall: expose `arc_max` ZFS option for PVE installations > > test: add tests for zfs_arc_max calculations > > common: add ZFS `arc_max` installer setup option > > tui: bootdisk: expose `arc_max` ZFS option for PVE installations > > > > applied series, thanks! Thanks! > > Two thoughts though: > > - we could add the ARC input field for PBS and PMG too, but not use the > automatic-sizing heuristic there (i.e., still 50% memory by default) Makes sense, esp. for PBS due to its nature. I'll look into it sometime! > > - maybe GB with float would fit in better, but surely not perfect either, > so just for the record. Good point, but I agree, hard to judge what's better. As we are defaulting to max. 16 GiB (for PVE), it's a rather smaller range, so MiB makes sense IMO. Although aligning it with all the other inputs, which are in GiB, makes sense too. As well as inputting it as GiB float should be precise enough for any case. I will definitely keep it in mind for the future.