From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 8ED941FF195
for <inbox@lore.proxmox.com>; Fri, 7 Mar 2025 17:05:09 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6EBE71F92B;
Fri, 7 Mar 2025 17:05:02 +0100 (CET)
Date: Fri, 7 Mar 2025 17:04:58 +0100
From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Message-ID: <bgnpdtcsbkmmnpyltaq5dls7qxq6vhdbg2cibaihh6z55ab7l6@k6osvpgsvpdb>
Mail-Followup-To: Stefan Hanreich <s.hanreich@proxmox.com>,
pve-devel@lists.proxmox.com
References: <20250214133951.344500-1-g.goller@proxmox.com>
<20250214133951.344500-11-g.goller@proxmox.com>
<eea3854b-c2a9-4037-8849-86896032fe50@proxmox.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <eea3854b-c2a9-4037-8849-86896032fe50@proxmox.com>
User-Agent: NeoMutt/20241002-35-39f9a6
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.028 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH pve-manager 10/11] sdn: add fabric
edit/delete forms
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
>> diff --git a/www/manager6/sdn/fabrics/Common.js b/www/manager6/sdn/fabrics/Common.js
>> new file mode 100644
>> index 000000000000..72ec093fc928
>> --- /dev/null
>> +++ b/www/manager6/sdn/fabrics/Common.js
>> @@ -0,0 +1,222 @@
>> +Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>> + extend: 'Ext.grid.Panel',
>> + mixins: ['Ext.form.field.Field'],
>> +
>> + network_interfaces: undefined,
>> +
>> + selectionChange: function(_grid, _selection) {
>> + let me = this;
>> + me.value = me.getSelection().map((rec) => {
>> + delete rec.data.cidr;
>> + delete rec.data.cidr6;
>> + delete rec.data.selected;
>> + return PVE.Parser.printPropertyString(rec.data);
>
>maybe we could explicitly select the fields we want to include here, so
>this doesn't break when we add new fields?
Depends on which fields :)
If we add fields to the interface, it won't break, if we add more
"display-only" fields it will break.
Anyway this is a common component, so we would need to pass/add a check for
the protocol and then select the protocol specific attributes.
>> + updateSelectedInterfaces: function(values) {
>> + let me = this;
>> + if (values) {
>> + let recs = [];
>> + let store = me.getStore();
>> +
>> + for (const i of values) {
>> + let rec = store.getById(i.name);
>> + if (rec) {
>> + recs.push(rec);
>> + }
>> + }
>> + me.suspendEvent('change');
>> + me.setSelection();
>> + me.setSelection(recs);
>> + me.resumeEvent('change');
>> + } else {
>> + me.suspendEvent('change');
>> + me.setSelection();
>> + me.resumeEvent('change');
>> + }
>
>could avoid some duplication by moving the methods calls above / below
>the if/else
I can extract the resumeEvent call, but keeping suspendEvent within each
branch is safer. If store operations fail between suspend and resume,
we'd risk permanently disabling the 'change' event listener.
Thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel