Re: [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path

From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 pve-common 01/12] introduce PVE::Path
Date: Fri, 31 Jan 2025 13:33:15 +0100	[thread overview]
Message-ID: <bfae248c-de2c-486c-a058-e274e2b48597@proxmox.com> (raw)
In-Reply-To: <b1d89b2a-4fdc-4e2b-84e4-1c91abb6dbb5@proxmox.com>

Am 31.01.25 um 13:23 schrieb Fiona Ebner:
> Am 09.01.25 um 15:48 schrieb Max Carrara:
>> +=head3 path_join(@paths)
>> +
>> +Joins multiple paths together. All kinds of paths are supported.
>> +
>> +Does not perform any C<L<< normalization|/"path_normalize($path)" >>>.
>> +
>> +    my $joined = path_join("foo", "bar/baz", "qux.txt");
>> +    # foo/bar/baz/qux.txt
>> +
>> +    my $joined = path_join("/", "etc/pve/", "storage.cfg");
>> +    # /etc/pve/storage.cfg
>> +
>> +Similar to C<L<< path_push()|/"path_push($path, $other)">>>, should any of the
>> +C<@paths> be an absolute path, it I<replaces> all preceding paths.
> 
> Seems like the docs are somehow broken here, looking at it with perldoc,
> it just states 'Similar to "path_push()"' and the rest of the sentence
> is missing.
> 

perldoc src/PVE/Path.pm will tell you at the end:

POD ERRORS
    Hey! The above document had some coding errors, which are explained
    below:

    Around line 160:
        Unknown directive: =items

    Around line 209:
        Unterminated C<L< ... >> sequence


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel