From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6F5261FF163 for ; Thu, 7 Nov 2024 11:39:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0D2C31E420; Thu, 7 Nov 2024 11:40:08 +0100 (CET) Message-ID: Date: Thu, 7 Nov 2024 11:40:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Maximiliano Sandoval References: <20240802143736.172810-1-m.sandoval@proxmox.com> From: Aaron Lauterer In-Reply-To: <20240802143736.172810-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: allow decompressing ISO compressed with bz2 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Tested in combination with the adjacent backend patch [0] by Downloading a bz2 compressed ISO and booting a VM from it. One small style nit inline, but I don't think that warants a new version, as we can fix it in a follow up or just directly when applying the patch. [0] https://lore.proxmox.com/pve-devel/d92e4078-00bf-48ad-9be8-afaeaf7398be@proxmox.com/T/#m6cff68830fd5356ebddfff8cee7f4b8c7d7770bd Tested-By: Aaron Lauterer Reviewed-By: Aaron Lauterer On 2024-08-02 16:37, Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > > This is a follow-up of the patch: > > [PATCH storage] storage: add bzip2 support > > which can be found at [1]. > > [1] https://lists.proxmox.com/pipermail/pve-devel/2024-August/065030.html > > > www/manager6/window/DownloadUrlToStorage.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/window/DownloadUrlToStorage.js b/www/manager6/window/DownloadUrlToStorage.js > index 5523a152..9cd44d5c 100644 > --- a/www/manager6/window/DownloadUrlToStorage.js > +++ b/www/manager6/window/DownloadUrlToStorage.js > @@ -84,7 +84,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', { > let filename = data.filename || ""; > let compression = '__default__'; > if (view.content === 'iso') { > - const matches = filename.match(/^(.+)\.(gz|lzo|zst)$/i); > + const matches = filename.match(/^(.+)\.(gz|lzo|zst|bz2)$/i); > if (matches) { > filename = matches[1]; > compression = matches[2].toLowerCase(); > @@ -228,6 +228,7 @@ Ext.define('PVE.window.DownloadUrlToStorage', { > ['lzo', 'LZO'], > ['gz', 'GZIP'], > ['zst', 'ZSTD'], > + ['bz2', 'bzip2'], All the other options in the list are all-caps. We probably want this also to be BZIP2 to not break the overall theme here. > ], > cbind: { > hidden: get => get('content') !== 'iso', _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel