From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 4432A1FF16B
	for <inbox@lore.proxmox.com>; Thu, 20 Feb 2025 18:52:12 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 549C319356;
	Thu, 20 Feb 2025 18:52:12 +0100 (CET)
Message-ID: <bf58ec87-81d0-4b3e-a31e-dacb68e87445@proxmox.com>
Date: Thu, 20 Feb 2025 18:52:09 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Fiona Ebner <f.ebner@proxmox.com>,
 Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250211160825.254167-1-d.kral@proxmox.com>
 <20250211160825.254167-24-d.kral@proxmox.com>
 <2b549a4a-d9c4-47da-9eb2-2b782ff1dab1@proxmox.com>
Content-Language: en-US
From: Daniel Kral <d.kral@proxmox.com>
In-Reply-To: <2b549a4a-d9c4-47da-9eb2-2b782ff1dab1@proxmox.com>
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.009 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container v2 03/11] alloc_disk: fail fast if
 storage does not support content type rootdir
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

On 2/20/25 13:15, Fiona Ebner wrote:
> I'd change the title to "alloc disk: fix content type check for ZFS
> storages" because the check was missing for that branch ;)
> 
> The commit message should mention that there are already earlier checks
> for the create operations. Moving a volume to a ZFS storage without
> 'rootdir' content type was still possible however, which this change
> prohibits.

Nice catch, thanks for pointing that out! Haven't noticed that while 
doing the refactor and will adapt the patch message as suggested for the 
v3 :).

On 2/20/25 13:15, Fiona Ebner wrote:
> I also noticed that we have no check against starting a container with
> volumes on a storage that does not support 'rootdir'. We have such a
> check for VMs IIRC. Prohibiting that would also be good, but maybe
> something for PVE 9 where we can also check for misconfigured
> containers/storages via the pve8to9 script up front so users can adapt.

Sounds good to have them both act the same in that regard! Put it on my 
pve-9 todo list for now.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel