From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 69EFF1FF16B
for <inbox@lore.proxmox.com>; Thu, 6 Mar 2025 13:15:08 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 02438515E;
Thu, 6 Mar 2025 13:15:04 +0100 (CET)
Message-ID: <bf081277-b97e-4bcf-b90f-8737e873d038@proxmox.com>
Date: Thu, 6 Mar 2025 13:15:00 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250306104459.1272297-1-d.csapak@proxmox.com>
<20250306104459.1272297-3-d.csapak@proxmox.com>
<0e5bf049-0f93-423f-b1b2-c14617f3fb40@proxmox.com>
Content-Language: en-US
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <0e5bf049-0f93-423f-b1b2-c14617f3fb40@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.022 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server 2/8] config to command: add one
'-global' option for each flag
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 3/6/25 13:13, Fiona Ebner wrote:
> Am 06.03.25 um 11:44 schrieb Dominik Csapak:
>> If we have multiple 'globalFlags', we have to encode each one separately
>> on the commandline with '-global OPTION', since QEMU does not allow to
>> have multiple options here.
>>
>> We currently only have one such flag that used the 'globalFlags' list,
>> so it never popped up. (All other uses directly add an option to the
>> commandline)
>>
>> Avoid future bugs by fixing it now.
>>
>
> So there is no real point to collecting the flags in the first place?
> I.e. we could also get rid of the variable and have the single current
> user of the variable add the flag directly on the commandline too. Or
> otherwise, we could change the other users and collect all flags with
> this variable. Pre-existing of course, but ideally, we could avoid the
> mishmash.
>
Sorry this could have been more clear here:
I add to the flags in one of the following patches, so i sent this
in preparation of that (could possibly be squashed)
I did not want to touch the other places, since that in turn changes
the order of the qemu commandline (which sometimes has unintended side
effects, e.g. in combination with the 'args' parameter)
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
>
>> ---
>> PVE/QemuServer.pm | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index b6fc1f17..13af495d 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -4001,7 +4001,9 @@ sub config_to_command {
>> push @$cmd, @$devices;
>> push @$cmd, '-rtc', join(',', @$rtcFlags) if scalar(@$rtcFlags);
>> push @$cmd, '-machine', join(',', @$machineFlags) if scalar(@$machineFlags);
>> - push @$cmd, '-global', join(',', @$globalFlags) if scalar(@$globalFlags);
>> + for my $flag ($globalFlags->@*) {
>> + push @$cmd, '-global', $flag;
>> + }
>>
>> if (my $vmstate = $conf->{vmstate}) {
>> my $statepath = PVE::Storage::path($storecfg, $vmstate);
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel