From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with UTF8SMTPS id C2AC67076F for ; Mon, 7 Jun 2021 12:33:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with UTF8SMTP id B90D2100A7 for ; Mon, 7 Jun 2021 12:32:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with UTF8SMTPS id E956B10099 for ; Mon, 7 Jun 2021 12:32:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with UTF8SMTP id C2B334292A for ; Mon, 7 Jun 2021 12:32:55 +0200 (CEST) Message-ID: Date: Mon, 7 Jun 2021 12:32:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:89.0) Gecko/20100101 Thunderbird/89.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20210607103158.21038-1-d.csapak@proxmox.com> From: Dominik Csapak In-Reply-To: <20210607103158.21038-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.978 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: ceph/Pools: defuse min_size warning X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2021 10:33:29 -0000 argh a typo slipped through... On 6/7/21 12:31, Dominik Csapak wrote: > we should not warn for the ceph built-in default warnings for min_size the word 'warnings' should not be there... > having the min_size half of the size (rounded up) is ok and > even the default for ceph > > since there seems to be no 'quorum based' pg inconsistency recovery[0], > only a copy from the authoritative osd, there is nothing wrong > with setting that. > > 0: https://docs.ceph.com/en/latest/rados/operations/pg-repair/ > > Signed-off-by: Dominik Csapak > --- > www/manager6/ceph/Pool.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js > index 41c08c39..41df216e 100644 > --- a/www/manager6/ceph/Pool.js > +++ b/www/manager6/ceph/Pool.js > @@ -28,7 +28,7 @@ Ext.define('PVE.CephPoolInputPanel', { > allowBlank: false, > listeners: { > change: function(field, val) { > - let size = Math.round((val + 1) / 2); > + let size = Math.round(val / 2); > if (size > 1) { > field.up('inputpanel').down('field[name=min_size]').setValue(size); > } > @@ -82,7 +82,7 @@ Ext.define('PVE.CephPoolInputPanel', { > let panel = field.up('inputpanel'); > let size = panel.down('field[name=size]').getValue(); > > - let showWarning = minSize <= size / 2 && minSize !== size; > + let showWarning = minSize < (size / 2) && minSize !== size; > > let fieldLabel = gettext('Min. Size'); > if (showWarning) { > @@ -97,7 +97,7 @@ Ext.define('PVE.CephPoolInputPanel', { > xtype: 'displayfield', > name: 'min_size-warning', > userCls: 'pmx-hint', > - value: gettext('min_size <= size/2 can lead to data loss, incomplete PGs or unfound objects.'), > + value: gettext('min_size < size/2 can lead to data loss, incomplete PGs or unfound objects.'), > hidden: true, > }, > { >