From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BE6938A8A3 for <pve-devel@lists.proxmox.com>; Wed, 27 Jul 2022 13:19:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8D7548B5 for <pve-devel@lists.proxmox.com>; Wed, 27 Jul 2022 13:19:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 27 Jul 2022 13:19:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D999142C82; Wed, 27 Jul 2022 13:19:34 +0200 (CEST) Message-ID: <bde6dd39-882c-5dff-1681-6118c302d63b@proxmox.com> Date: Wed, 27 Jul 2022 13:19:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, aderumier@odiso.com References: <20220622115206.3295425-1-aderumier@odiso.com> From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20220622115206.3295425-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v7 qemu-server 00/10] cloudinit pending behaviour change X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 27 Jul 2022 11:19:35 -0000 Am 22.06.22 um 13:51 schrieb Alexandre Derumier: > Hi, > > This is an attempt to cleanup current behaviour of cloudinit online changes. > > Currently, we setup cloudinit options as pending, until we generate the config drive. > > This is not 100% true, because some option like vm name, nic mac address can be changed, > without going to pending, so user can't known if it need to regenerated it. > > Also, some can are very difficult to handle, if you hotplug a nic but it's failing,so pending, > then you defined an ipconfig, and then you revert hotplug. > or if you delete a nic, the ipconfig is no more displayed in the gui. > > > So, instead of setting cloudinit values in pending, > this patch serie copy the current cloudinit config in a new section [special:cloudinit], > when the config drive is generated. > This is only an hint, to allow to display diff between the generated cloudinit > drive, and the current vm config. > > A new specific cloudinit config api is added too displaying the diff between current and generated config. > > Reminder: This need pve-manager depency bump first to check the version for live migration. Without 10/10 and the version check in 03/10 adapted in accordance with the above-mentioned bump (best done when applying): Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>