From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 162879BB7A for ; Tue, 21 Nov 2023 13:34:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EE1658CBE for ; Tue, 21 Nov 2023 13:34:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 21 Nov 2023 13:34:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2FEB941410 for ; Tue, 21 Nov 2023 13:34:42 +0100 (CET) Message-ID: Date: Tue, 21 Nov 2023 13:34:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Lukas Wagner , Proxmox VE development discussion References: <20231121102208.82219-1-l.wagner@proxmox.com> <6dd1ceba-07be-43a9-aef3-8ebfc020aec8@proxmox.com> <786a840a-6c99-4a6b-946c-c2413afee735@proxmox.com> From: Fiona Ebner In-Reply-To: <786a840a-6c99-4a6b-946c-c2413afee735@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 guest-common/manager 0/4] vzdump: add 'notification-mode' parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2023 12:34:43 -0000 Am 21.11.23 um 13:13 schrieb Lukas Wagner: > On 11/21/23 11:55, Fiona Ebner wrote: >> Am 21.11.23 um 11:22 schrieb Lukas Wagner: >>> This should provide a fix/workaround for the users' reports of >>>    - double notifications (these happened in case mailto was set to >>> the same address >>>      as root@pam) >> >> Can't we detect and avoid this more easily? > > There would be other ways to solve this, yes. I could also deduplicate > email-addresses in the backend - which isn't is as trivial as it sounds, > since the 'legacy' mails are sent via separate, temporary target of > type 'sendmail' - so essentially I'd need to have 'cross-target' context > or something alike. > Okay, I hoped you could get the information about whether the 'mailto' address is already notified via existing targets more easily. >> >>>    - notifications always being sent, even if 'mailnotification' is >>> set to failure >> >> Can't we just treat 'failure' mode as always defaulting to legacy >> sendmail? And properly deprecate the setting, showing a warning/info >> that new notification system is not used if set to 'failure' for both >> CLI and UI. And maybe not even allow setting it for new jobs/manual >> backups? > > I think an explicit switch here is much more obvious and predictable to > the user. > But also more complexity/mental load for both them and us. And having a deprecation warning would also be obvious and predictable ;) Sure, we (most likely) can get rid of the extra switch with PVE 9, was just hoping for something simpler. But if that's not easily possible, then let's go with the switch. > Personally I think we should wait a bit before deprecating/disallowing > 'mailto' for new backup jobs. This gives us time to polish the UX of > creating matchers etc. without 'forcing' the user into the new system. > I didn't mean deprecating 'mailto' like that, just 'mailnotification' (being set to 'failure').