From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 35E2B1FF164 for ; Fri, 6 Dec 2024 11:21:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3614320A7; Fri, 6 Dec 2024 11:21:19 +0100 (CET) Date: Fri, 6 Dec 2024 11:20:46 +0100 From: Gabriel Goller To: Lukas Wagner Message-ID: References: <20241206101007.156910-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241206101007.156910-1-l.wagner@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [smtp.rs] Subject: Re: [pve-devel] [PATCH proxmox 1/2] notify: smtp: add missing 'tracing' namespace prefix X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 06.12.2024 11:10, Lukas Wagner wrote: >This section of code is only compiled when the 'mail-forwarder' feature >is enabled, which might have been the reason why this was missed when the >other places where log messages are produced were migrated to 'tracing'. Oh that's why I didn't get an error when compiling. Anyway consider: Reviewed-by: Gabriel Goller > >Signed-off-by: Lukas Wagner >--- > proxmox-notify/src/endpoints/smtp.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/proxmox-notify/src/endpoints/smtp.rs b/proxmox-notify/src/endpoints/smtp.rs >index 6bb2d2d0..86911f9b 100644 >--- a/proxmox-notify/src/endpoints/smtp.rs >+++ b/proxmox-notify/src/endpoints/smtp.rs >@@ -336,7 +336,7 @@ impl Endpoint for SmtpEndpoint { > let header = HeaderValue::new(name, value); > message.headers_mut().insert_raw(header); > } >- Err(e) => error!("could not set header: {e}"), >+ Err(e) => tracing::error!("could not set header: {e}"), > } > } > } >-- >2.39.5 > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel