From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EF4BB617E3 for ; Thu, 17 Dec 2020 16:35:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBD2D28828 for ; Thu, 17 Dec 2020 16:35:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 342BC2881B for ; Thu, 17 Dec 2020 16:35:53 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 06A5845255; Thu, 17 Dec 2020 16:35:53 +0100 (CET) To: Proxmox VE development discussion , Andrei Perapiolkin References: From: Thomas Lamprecht Message-ID: Date: Thu, 17 Dec 2020 16:35:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.065 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] Adding new data storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Dec 2020 15:35:54 -0000 Hi, On 17/12/2020 16:06, Andrei Perapiolkin wrote: > I would like to add new data storage. This storage would resemble ZFS over iSCSI but will use different API to access storage. > What do you mean here, what API will it use? If you want to include this in our repository some more details would be appreciated. Else, for storages with have a external plugin system which can be used to include plugins which are proprietary or otherwise unfit for inclusion. > Should I create/provide anything besides pve-storage/PVE/Storage/.pm ? Once above is cleared, then yes, and base it off the closed related storage plugin - i.e., maybe ZFS, else the base plugin. > > > Is there any documentation I should familiarize myself with beside coding style? our Perl style guide is here: https://pve.proxmox.com/wiki/Perl_Style_Guide Besides that, check the developer documentation in general, especially those two sections: https://pve.proxmox.com/wiki/Developer_Documentation#Preparing_Patches https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright regards, Thomas