From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0B5006F857 for ; Tue, 31 Aug 2021 09:52:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E4DFC22754 for ; Tue, 31 Aug 2021 09:51:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4D60622748 for ; Tue, 31 Aug 2021 09:51:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1CE104421C for ; Tue, 31 Aug 2021 09:51:58 +0200 (CEST) Message-ID: Date: Tue, 31 Aug 2021 09:51:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Thunderbird/92.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20210803121640.2530993-1-l.stechauner@proxmox.com> <20210803121640.2530993-3-l.stechauner@proxmox.com> <03cd9b76-a623-4c4f-01a0-4282b028abb8@proxmox.com> <231a41af-998a-4a99-9d3d-d20f78064512@proxmox.com> From: Thomas Lamprecht In-Reply-To: <231a41af-998a-4a99-9d3d-d20f78064512@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.793 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.932 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2021 07:52:29 -0000 On 30.08.21 13:54, Lorenz Stechauner wrote: > On 26.08.21 18:30, Thomas Lamprecht wrote: >> On 03/08/2021 14:16, Lorenz Stechauner wrote: >>> @@ -486,6 +486,7 @@ __PACKAGE__->register_method ({ >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 print "command= : " . join(' ', @$cmd) . "\n"; >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 eval { = run_command($cmd, errmsg =3D> 'import failed'); }; >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unlink $tmpfilename or wa= rn "unable to clean up temporary file '$tmpfilename' - $!"; >> and doesn't this have the same issues as you recently fixed in regards= to the node >> not being the local one and thus ssh/scp being used? > in this case, the local temp file is deleted and this is intended. prev= iously, this was done by the http server. > but it would be better to clean up the remote file as well and therefor= e a ssh command has to be used - could be another commit Oh, you're right, this is only the intermediate uploaded file which is al= ways local. A comment could be great for that detail, but I can add that one as follo= w up.