From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id F3A5A1FF16E
for <inbox@lore.proxmox.com>; Mon, 3 Mar 2025 10:25:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0D1F55E88;
Mon, 3 Mar 2025 10:25:40 +0100 (CET)
Message-ID: <bc6f8d47-eca6-4cbd-9152-1a74e7082d0b@proxmox.com>
Date: Mon, 3 Mar 2025 10:25:36 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
References: <20250228145022.73966-1-f.ebner@proxmox.com>
Content-Language: en-US
In-Reply-To: <20250228145022.73966-1-f.ebner@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.293 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URI_NOVOWEL 0.5 URI hostname has long non-vowel sequence
Subject: Re: [pve-devel] [PATCH-SERIES storage 0/6] unsized subvol
regression fix and improvements
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Superseded by v2:
https://lore.proxmox.com/pve-devel/20250303092445.13873-1-f.ebner@proxmox.com/T/#maf24450cef1ab5c66467e3ceb5c4c073fee69fa8
Am 28.02.25 um 15:50 schrieb Fiona Ebner:
> In list context, the file_size_info() function in Plugin.pm and the
> volume_size_info() function in BTRFSPlugin.pm would return 0 for the
> size, but in scalar context 1. As reported in the community forum [0],
> the change in commit e50dde0 ("volume export: rely on storage plugin's
> format"), changing the caller in volume_export() to scalar context
> exposed the inconsistency in the return value for the size. This led
> to breakage of migration with unsized btrfs subvolumes.
>
> The first patch is the regression fix. Second patch fixes cloning
> containers with unsized subvolumes on BTFRS. The rest are independent
> further cleanups or improvements in the context of unsized subvols.
>
> [0]: https://forum.proxmox.com/threads/162943/
>
> Fiona Ebner (6):
> plugin: file size info: be consistent about size of directory subvol
> btrfs: fix volume size info for subvolumes in scalar context
> plugin: volume export formats: avoid superfluous file_size_info() call
> api: volume info: do not fail for zero-sized subvolumes
> btrfs: die early for broken subvolume resize
> btrfs: note that btrfs_get_subvol_id() function is broken
>
> src/PVE/API2/Storage/Content.pm | 4 +++-
> src/PVE/Storage/BTRFSPlugin.pm | 6 +++++-
> src/PVE/Storage/Plugin.pm | 5 +----
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel