From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id B511B1FF15E
for <inbox@lore.proxmox.com>; Tue, 6 May 2025 11:39:48 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 7CE575B50;
Tue, 6 May 2025 11:40:03 +0200 (CEST)
Message-ID: <bc156063-829d-43c4-9b2e-599fc6e35e47@proxmox.com>
Date: Tue, 6 May 2025 11:40:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20250422115141.808427-1-alexandre.derumier@groupe-cyllene.com>
<mailman.19.1745322716.394.pve-devel@lists.proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <mailman.19.1745322716.394.pve-devel@lists.proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.035 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH qemu-server 01/14] tests: add cfg2cmd
for disk passthrough, rbd, krbd && zfs-over-scsi.
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 22.04.25 um 13:51 schrieb Alexandre Derumier via pve-devel:
> Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
> ---
> test/cfg2cmd/simple-disk-passthrough.conf | 15 ++++++++
> test/cfg2cmd/simple-disk-passthrough.conf.cmd | 37 +++++++++++++++++++
> test/cfg2cmd/simple-rbd.conf | 15 ++++++++
> test/cfg2cmd/simple-rbd.conf.cmd | 37 +++++++++++++++++++
> test/cfg2cmd/simple-zfs-over-iscsi.conf | 14 +++++++
> test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd | 35 ++++++++++++++++++
> test/run_config2command_tests.pl | 34 +++++++++++++++++
> 7 files changed, 187 insertions(+)
> create mode 100644 test/cfg2cmd/simple-disk-passthrough.conf
> create mode 100644 test/cfg2cmd/simple-disk-passthrough.conf.cmd
> create mode 100644 test/cfg2cmd/simple-rbd.conf
> create mode 100644 test/cfg2cmd/simple-rbd.conf.cmd
> create mode 100644 test/cfg2cmd/simple-zfs-over-iscsi.conf
> create mode 100644 test/cfg2cmd/simple-zfs-over-iscsi.conf.cmd
applied, with the following diff on top, thanks!
> diff --git a/test/run_config2command_tests.pl b/test/run_config2command_tests.pl
> index 90bdaa12..f94d9c02 100755
> --- a/test/run_config2command_tests.pl
> +++ b/test/run_config2command_tests.pl
> @@ -16,6 +16,7 @@ use PVE::SysFSTools;
>
> use PVE::QemuConfig;
> use PVE::QemuServer;
> +use PVE::QemuServer::Drive;
> use PVE::QemuServer::Helpers;
> use PVE::QemuServer::Monitor;
> use PVE::QemuServer::QMPHelpers;
> @@ -73,13 +74,13 @@ my $base_env = {
> monhost => '127.0.0.42,127.0.0.21,::1',
> fsid => 'fc4181a6-56eb-4f68-b452-8ba1f381ca2a',
> content => {
> - images => 1
> + images => 1,
> },
> type => 'rbd',
> pool => 'cpool',
> username => 'admin',
> shared => 1,
> - krbd => 1
> + krbd => 1,
> },
> 'zfs-over-iscsi-store' => {
> type => 'zfs',
> @@ -89,7 +90,7 @@ my $base_env = {
> target => "iqn.2019-10.org.test:foobar",
> pool => "tank",
> content => {
> - images => 1
> + images => 1,
> },
> },
> 'local-lvm' => {
> @@ -253,8 +254,7 @@ $zfsplugin_module->mock(
> },
> zfs_get_lun_number => sub {
> return "0";
> - }
> -
> + },
> );
>
> my $qemu_server_config;
> @@ -401,6 +401,14 @@ $pve_common_sysfstools->mock(
> },
> );
>
> +my $qemu_drive_module;
> +$qemu_drive_module = Test::MockModule->new('PVE::QemuServer::Drive');
> +$qemu_drive_module->mock(
> + get_cdrom_path => sub {
> + return "/dev/cdrom";
> + },
> +);
> +
> my $qemu_monitor_module;
> $qemu_monitor_module = Test::MockModule->new('PVE::QemuServer::Monitor');
> $qemu_monitor_module->mock(
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel