From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1EA94C0BB for ; Mon, 2 May 2022 16:32:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1614428DD2 for ; Mon, 2 May 2022 16:32:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 95F8928DC7 for ; Mon, 2 May 2022 16:32:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 64BE642975 for ; Mon, 2 May 2022 16:32:41 +0200 (CEST) Message-ID: Date: Mon, 2 May 2022 16:32:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Content-Language: en-US To: Proxmox VE development discussion , Matthias Heiserer References: <20220502142423.749183-1-m.heiserer@proxmox.com> From: Aaron Lauterer In-Reply-To: <20220502142423.749183-1-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.969 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.943 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 14:32:42 -0000 thanks for catching this! Tested-By: Aaron Lauterer On 5/2/22 16:24, Matthias Heiserer wrote: > They are not used anywhere else, so I assume they were left over from > an earlier version. > Also, sometimes "[object object] flashes in the Target Guest field when > opening the reassign window, with this removed it doesn't occur. > > Signed-off-by: Matthias Heiserer > --- > www/manager6/window/GuestDiskReassign.js | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js > index 3795475d..f6d08b32 100644 > --- a/www/manager6/window/GuestDiskReassign.js > +++ b/www/manager6/window/GuestDiskReassign.js > @@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', { > }, > { > xtype: 'vmComboSelector', > - reference: 'targetVMID', > name: 'targetVmid', > allowBlank: false, > fieldLabel: gettext('Target Guest'), > - bind: { > - value: '{targetVMID}', > - }, > store: { > model: 'PVEResources', > autoLoad: true,