From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 617961FF137 for ; Tue, 31 Mar 2026 16:28:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5199F1F493; Tue, 31 Mar 2026 16:29:09 +0200 (CEST) Message-ID: Date: Tue, 31 Mar 2026 16:29:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-SERIES qemu-server 0/2] hotplug pending: only issue QMP commands related to USB hotplug if actually needed To: pve-devel@lists.proxmox.com References: <20260330110954.82174-1-f.ebner@proxmox.com> Content-Language: en-US From: Manuel Federanko In-Reply-To: <20260330110954.82174-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774967286337 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.545 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2EZOH6QHQ57L5XFC2VT4JQSQ47GLNTIF X-Message-ID-Hash: 2EZOH6QHQ57L5XFC2VT4JQSQ47GLNTIF X-MailFrom: m.federanko@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2026-03-30 1:09 PM, Fiona Ebner wrote: > There is a report in the enterprise support about Veeam failing to set > the 'lock' property in the VM configuration, because they are blocking > the QMP socket. The proper fix would be for them to not block the QMP > socket (at least not while interacting with our API), but there still > is an improvement to be made on the Proxmox VE side, which is to avoid > doing QMP commands related to USB hotplug if they are not actually > needed. > > qemu-server: > > Fiona Ebner (2): > hotplug pending: only check if USB devices are left when one was > unplugged > hotplug pending: only check for USB hoptplug support when actually > needed > > src/PVE/QemuServer.pm | 41 ++++++++++++++++++++++++++++++----------- > 1 file changed, 30 insertions(+), 11 deletions(-) > > > Summary over all repositories: > 1 files changed, 30 insertions(+), 11 deletions(-) > Thanks! Tested this by blocking the QMP socket and acquiring a lock on the guest afterwards, also tried to add a USB device while blocking the socket, which times out as expected. Tested-by: Manuel Federanko