From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] api: create disks: also convert tpmstate and efidisk to base image for templates
Date: Mon, 13 Jan 2025 16:34:39 +0100 [thread overview]
Message-ID: <bb6d840a-ad59-4827-b6a7-ebe3681d111b@proxmox.com> (raw)
In-Reply-To: <20250110170532.204262-1-d.kral@proxmox.com>
Am 10.01.25 um 18:05 schrieb Daniel Kral:
> The commit 37a1f42a introduced a conversion step for newly allocated
> volume disks to base volumes for VM templates. This wrongly excluded
> efidisk and tmpstate volumes from this conversion, even though those
> should be converted to base volumes too.
>
> Therefore, include efidisks and tpmstate volumes to be converted to base
> volumes when newly allocating them.
>
> Suggested-by: Fiona Ebner <f.ebner@proxmox.com>
> Fixes: 37a1f42a ("fix #5301: convert added volume disks to base images for templates")
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-01-13 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 17:05 [pve-devel] " Daniel Kral
2025-01-13 15:34 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6d840a-ad59-4827-b6a7-ebe3681d111b@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox