From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0977581A9B for ; Thu, 25 Nov 2021 14:34:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 073CCDAA1 for ; Thu, 25 Nov 2021 14:34:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6E1BCDA93 for ; Thu, 25 Nov 2021 14:34:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 43B444690D; Thu, 25 Nov 2021 14:34:55 +0100 (CET) Message-ID: Date: Thu, 25 Nov 2021 14:34:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20211109141359.990235-1-o.bektas@proxmox.com> <20211109141359.990235-3-o.bektas@proxmox.com> From: Dominik Csapak In-Reply-To: <20211109141359.990235-3-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.248 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.1 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fedorapeople.org, nodes.pm] Subject: Re: [pve-devel] [PATCH manager 2/2] set https_proxy to http_proxy for querying url metadata X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Nov 2021 13:34:56 -0000 this sadly does not work, comment inline On 11/9/21 15:13, Oguz Bektas wrote: > we can reuse the same 'http_proxy' from datacenter.cfg file. > requests made this way go via a http 'CONNECT'. > > $ tail -f /var/log/squid/access.log > ... > 1636466841.211 463 127.0.0.1 TCP_TUNNEL/200 4717 CONNECT fedorapeople.org:443 - HIER_DIRECT/152.19.134.199 - > 1636466841.696 481 127.0.0.1 TCP_TUNNEL/200 4725 CONNECT fedorapeople.org:443 - HIER_DIRECT/152.19.134.199 - > 1636466842.179 480 127.0.0.1 TCP_TUNNEL/200 4783 CONNECT fedorapeople.org:443 - HIER_DIRECT/152.19.134.199 - > > > Signed-off-by: Oguz Bektas > --- > PVE/API2/Nodes.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index 565cbccc..1e13285c 100644 > --- a/PVE/API2/Nodes.pm > +++ b/PVE/API2/Nodes.pm > @@ -1548,7 +1548,7 @@ __PACKAGE__->register_method({ > > my $dccfg = PVE::Cluster::cfs_read_file('datacenter.cfg'); > if ($dccfg->{http_proxy}) { > - $ua->proxy('http', $dccfg->{http_proxy}); > + $ua->proxy("['http', 'https']", $dccfg->{http_proxy}); the protocols must be an arrayref, not a string so $ua->proxy(['http', 'https'], ...) would be correct > } > > my $verify = $param->{'verify-certificates'} // 1; >