From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 835377862B
 for <pve-devel@lists.proxmox.com>; Tue, 28 Jun 2022 12:54:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 79E95A252
 for <pve-devel@lists.proxmox.com>; Tue, 28 Jun 2022 12:54:58 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 6637EA245
 for <pve-devel@lists.proxmox.com>; Tue, 28 Jun 2022 12:54:57 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2815140428
 for <pve-devel@lists.proxmox.com>; Tue, 28 Jun 2022 12:54:57 +0200 (CEST)
Message-ID: <bb116765-f635-11ac-d046-222ce31256b6@proxmox.com>
Date: Tue, 28 Jun 2022 12:54:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-US
To: pve-devel@lists.proxmox.com, Stefan Hrdlicka <s.hrdlicka@proxmox.com>
References: <20220622143929.2757681-1-s.hrdlicka@proxmox.com>
 <20220622143929.2757681-3-s.hrdlicka@proxmox.com>
From: Fabian Ebner <f.ebner@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20220622143929.2757681-3-s.hrdlicka@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.048 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH V2 manager 2/3] cleanup: "var" to "let",
 fix some indentation in related files
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2022 10:54:58 -0000

Am 22.06.22 um 16:39 schrieb Stefan Hrdlicka:
> replace all "var" with "let" in files related to patch for ticket 2822
> 
> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>

While this patch can be fine, I think the next one is a bit too big ;)
It might introduce subtle bugs (since we might be relying on the
semantics of var somewhere) and I'd rather continue having the
conversion be done organically for a while, with patches limited in
scope (pun intended) like this one being okay.

@Dominik, @Thomas opinions?